Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEC-454 TLS small refactor, remove TLS footgun, multi-roll handling #83

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

arrowplum
Copy link
Contributor

@arrowplum arrowplum commented Dec 17, 2024

Script now does not let you install with tls and roles until that is supported and other ease of use changes.

❯  ./full-create-and-install-gke.sh --help
Usage: ./full-create-and-install-gke.sh [options]
Options:
  --chart-location, -l <path>  If specified expects a local directory for AVS Helm chart (default: official repo)
  --cluster-name, -c <name>    Override the default cluster name (default: joem-performance-eco-avs)
  --machine-type, -m <type>    Specify the machine type (default: n2d-standard-4)
  --num-avs-nodes, -a <num>     Specify the number of AVS nodes (default: 3)
  --num-query-nodes, -q <num>  Specify the number of AVS query nodes (default: 0)
  --num-index-nodes, -i <num>  Specify the number of AVS index nodes (default: 0)
  --num-aerospike-nodes, -s <num>  Specify the number of Aerospike nodes (default: 3)
  --run-insecure, -I           Run setup cluster without auth or tls. No argument required.
  --help, -h                   Show this help message

@arrowplum arrowplum requested review from hev and a-spiker and removed request for a-spiker December 17, 2024 01:03
@arrowplum arrowplum changed the title VEC-454 Add warnings for tls and easier to use k8s script VEC-454 TLS small refactor, remove TLS footgun, multi-roll handling Dec 17, 2024
@arrowplum arrowplum requested review from davi17g and hev and removed request for hev December 17, 2024 02:39
Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I was able to deploy clusters that don't really work (e.g. 0 index nodes) but this is a good improvement. This is probably ok. I do think we should coordinate this with the following docs change - https://github.com/citrusleaf/aerospike-websites/pull/1722

@arrowplum arrowplum merged commit f853f0b into main Dec 18, 2024
1 check passed
@arrowplum arrowplum deleted the parameterized branch December 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants