Skip to content

Commit

Permalink
fix index list header typos
Browse files Browse the repository at this point in the history
  • Loading branch information
dwelch-spike committed Oct 18, 2024
1 parent a5e0297 commit 4a9f93a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
5 changes: 3 additions & 2 deletions cmd/writers/indexList.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ func NewIndexTableWriter(writer io.Writer, verbose bool, logger *slog.Logger) *I
verboseHeadings,
"Vector Records",
"Vertices",
"Labels",
"Labels*",
"Storage",
"HNSW",
"Index Parameters",
)

if verbose {
Expand Down Expand Up @@ -113,6 +113,7 @@ func (itw *IndexTableWriter) AppendIndexRow(
{"Healer Parallelism*", v.HnswParams.HealerParams.GetParallelism()},
{"Merge Index Parallelism*", v.HnswParams.MergeParams.GetIndexParallelism()},
{"Merge Re-Index Parallelism*", v.HnswParams.MergeParams.GetReIndexParallelism()},
// TODO enable this when testing is done {"Enable Vector Integrity Check", v.HnswParams.GetEnableVectorIntegrityCheck()},
})

row = append(row, renderTable(tHNSW, format))
Expand Down
6 changes: 3 additions & 3 deletions e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -730,8 +730,8 @@ func (suite *CmdTestSuite) TestSuccessfulListIndexCmd() {
},
cmd: "index list --verbose --no-color --format 1",
expectedTable: `Indexes
,Name,Namespace,Set,Field,Dimensions,Distance Metric,Unmerged,Labels*,Storage,Index Parameters
1,list2,bar,barset,vector,256,HAMMING,0,map[],"Namespace\,bar
,Name,Namespace,Set,Field,Dimensions,Distance Metric,Unmerged,Vector Records,Vertices,Labels*,Storage,Index Parameters
1,list2,bar,barset,vector,256,HAMMING,0,0,0,map[],"Namespace\,bar
Set\,list2","HNSW
Max Edges\,16
Ef\,100
Expand All @@ -748,7 +748,7 @@ Healer Schedule*\,0 0/15 * ? * * *
Healer Parallelism*\,1
Merge Index Parallelism*\,80
Merge Re-Index Parallelism*\,26"
2,list1,test,,vector,256,COSINE,0,map[foo:bar],"Namespace\,test
2,list1,test,,vector,256,COSINE,0,0,0,map[foo:bar],"Namespace\,test
Set\,list1","HNSW
Max Edges\,16
Ef\,100
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module asvec
go 1.22.5

require (
github.com/aerospike/avs-client-go v0.0.0-20241017025432-3c27d1ca7ca1
github.com/aerospike/avs-client-go v0.0.0-20241017232653-891999137417
github.com/aerospike/tools-common-go v0.0.0-20240927170813-c352c1917359
github.com/jedib0t/go-pretty/v6 v6.5.9
github.com/spf13/cobra v1.8.1
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ github.com/aerospike/avs-client-go v0.0.0-20241001202601-cea4c0a9a32d h1:usIqwmi
github.com/aerospike/avs-client-go v0.0.0-20241001202601-cea4c0a9a32d/go.mod h1:gveJAyzXlND0g/lA+R6USRg9UcnGAUtyHzcngWrHSTo=
github.com/aerospike/avs-client-go v0.0.0-20241017025432-3c27d1ca7ca1 h1:SPN+c8CEkpfu4kgKM8oW4tgYc3EJIq2kOvEBMuWTNCk=
github.com/aerospike/avs-client-go v0.0.0-20241017025432-3c27d1ca7ca1/go.mod h1:gveJAyzXlND0g/lA+R6USRg9UcnGAUtyHzcngWrHSTo=
github.com/aerospike/avs-client-go v0.0.0-20241017232653-891999137417 h1:VWfR8GVLCP3uOttMAyBNA9mhIDFUhBQxNcx5Eoux/Y0=
github.com/aerospike/avs-client-go v0.0.0-20241017232653-891999137417/go.mod h1:gveJAyzXlND0g/lA+R6USRg9UcnGAUtyHzcngWrHSTo=
github.com/aerospike/tools-common-go v0.0.0-20240927170813-c352c1917359 h1:NXCigFN6GWJizwJSe7xAp5kTz7ZxdNjpyRxaIp6MkuA=
github.com/aerospike/tools-common-go v0.0.0-20240927170813-c352c1917359/go.mod h1:Ig1lRynXx0tXNOY3MdtanTsKz1ifG/2AyDFMXn3RMTc=
github.com/cpuguy83/go-md2man/v2 v2.0.4/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
Expand Down
2 changes: 0 additions & 2 deletions tests/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ func (idb *IndexDefinitionBuilder) Build() *protos.IndexDefinition {
Dimensions: uint32(idb.dimension),
VectorDistanceMetric: Ptr(idb.vectorDistanceMetric),
Field: idb.vectorField,
Type: Ptr(protos.IndexType_HNSW),
// Storage: ,
Params: &protos.IndexDefinition_HnswParams{
HnswParams: &protos.HnswParams{
Expand All @@ -199,7 +198,6 @@ func (idb *IndexDefinitionBuilder) Build() *protos.IndexDefinition {
Dimensions: uint32(idb.dimension),
VectorDistanceMetric: Ptr(idb.vectorDistanceMetric),
Field: idb.vectorField,
Type: Ptr(protos.IndexType_HNSW),
Storage: &protos.IndexStorage{},
Params: &protos.IndexDefinition_HnswParams{
HnswParams: &protos.HnswParams{
Expand Down

0 comments on commit 4a9f93a

Please sign in to comment.