Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vec 168 init #1

Merged
merged 35 commits into from
Jul 2, 2024
Merged

Vec 168 init #1

merged 35 commits into from
Jul 2, 2024

Conversation

jdogmcsteezy
Copy link

This initial PR has the following commands:

  • asvec create index
  • asvec drop index
  • asvec list index

It also includes a limited number of unit tests and e2e tests with 86% coverage.

Some early builds can be installed from the releases page

@jdogmcsteezy jdogmcsteezy requested review from arrowplum and reugn June 13, 2024 20:18
@jdogmcsteezy jdogmcsteezy self-assigned this Jun 13, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just have a few comments and questions, some for my understanding, nothing major. Once you've had a look this I think this is good to go.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
bin/asvecrpm/asvec.spec Show resolved Hide resolved
bin/asvecrpm/asvec.spec Show resolved Hide resolved
cmd/constants.go Show resolved Hide resolved
cmd/listIndex.go Show resolved Hide resolved
cmd/writers/indexList.go Show resolved Hide resolved
e2e_test.go Show resolved Hide resolved
e2e_test.go Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
@dwelch-spike dwelch-spike self-requested a review July 2, 2024 21:41
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass

@jdogmcsteezy jdogmcsteezy merged commit 938957b into main Jul 2, 2024
3 checks passed
@jdogmcsteezy jdogmcsteezy deleted the VEC-168-init branch July 2, 2024 21:44
@jdogmcsteezy jdogmcsteezy restored the VEC-168-init branch July 2, 2024 21:44
@jdogmcsteezy jdogmcsteezy deleted the VEC-168-init branch October 1, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants