-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vec 210 acl #3
Vec 210 acl #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some help text changes and nitpicks and suggestions
cmd/userRevoke.go
Outdated
func newUserRevokeFlagSet() *pflag.FlagSet { | ||
flagSet := &pflag.FlagSet{} | ||
flagSet.AddFlagSet(userRevokeFlags.clientFlags.NewClientFlagSet()) | ||
flagSet.StringVar(&userRevokeFlags.revokeUser, flags.Name, "", commonFlags.DefaultWrapHelpString("The existing user to grant new roles.")) //nolint:lll // For readability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flagSet.StringVar(&userRevokeFlags.revokeUser, flags.Name, "", commonFlags.DefaultWrapHelpString("The existing user to grant new roles.")) //nolint:lll // For readability | |
flagSet.StringVar(&userRevokeFlags.revokeUser, flags.Name, "", commonFlags.DefaultWrapHelpString("The existing user to revoke roles from.")) //nolint:lll // For readability |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=======================================
Coverage ? 84.70%
=======================================
Files ? 28
Lines ? 1308
Branches ? 0
=======================================
Hits ? 1108
Misses ? 153
Partials ? 47 ☔ View full report in Codecov by Sentry. |
LGTM |
Includes:
index create
vscreate index
user create
user ls
user drop
user grant
user revoke
user new-password
role ls