review changes

client.go

@@ -653,7 +653,7 @@ func (c *Client) WaitForIndexCompletion(
 	waitInterval time.Duration,
 ) error {
 	logger := c.logger.With(slog.String("namespace", namespace), slog.String("indexName", indexName))
-	logger.DebugContext(ctx, failedToWaitForIndexCompletion)
+	logger.DebugContext(ctx, "waiting for index completion")
 
 	conn, err := c.connectionProvider.GetRandomConn()
 	if err != nil {
@@ -703,9 +703,9 @@ func (c *Client) WaitForIndexCompletion(
 		select {
 		case <-timer.C:
 		case <-ctx.Done():
-			msg := "failed to wait for index completion"
+			msg := "waiting for index completion canceled"
 
-			logger.ErrorContext(ctx, "waiting for index completion canceled")
+			logger.ErrorContext(ctx, msg)
 
 			return NewAVSError(msg, ctx.Err())
 		}

connection_provider.go

@@ -530,11 +530,19 @@ func (cp *connectionProvider) getUpdatedEndpoints(ctx context.Context) map[uint6
 	}()
 
 	// Stores the endpoints from the node with the largest view of the cluster
+	// Think about a scenario where the nodes are split into two cluster
+	// momentarily and the client can see both. We are making the decision here
+	// to connect to the larger of the two formed cluster.
 	var largestNewCluster *idAndEndpoints
 	for cluster := range newClusterChan {
 		if largestNewCluster == nil || len(cluster.endpoints) > len(largestNewCluster.endpoints) {
 			largestNewCluster = cluster
-			cp.logger.DebugContext(ctx, "found new cluster ID", slog.Any("endpoints", largestNewCluster))
+			cp.logger.DebugContext(
+				ctx,
+				"largest cluster with new id",
+				slog.Any("endpoints", largestNewCluster.endpoints),
+				slog.Uint64("id", largestNewCluster.id),
+			)
 		}
 	}
 

makefile

@@ -66,5 +66,5 @@ view-coverage: $(COVERAGE_DIR)/total.cov
 	go tool cover -html=$(COVERAGE_DIR)/total.cov
 
 PHONY: lint
-lint: $(GOLANGCI_LINT)
+lint: $(GOLANGCI_LINT) mocks
 	$(GOLANGCI_LINT) run