Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vec-379 Support AVS 0.11.x #16

Merged
merged 13 commits into from
Oct 25, 2024
Merged

vec-379 Support AVS 0.11.x #16

merged 13 commits into from
Oct 25, 2024

Conversation

dwelch-spike
Copy link
Contributor

@dwelch-spike dwelch-spike commented Oct 15, 2024

  • Adds number of vectors and vertices in the index list/get methods.
  • Allows for infinite cache expiration using -1
  • Allow for caching vector records
  • Allow toggling vector integrity checks
  • Make multiple fields optional
  • Rename multiple fields

Summary of proto changes and their implications…

Adds…

indexStatusResponse

    indexHealerVectorRecordsIndexed

    indexHealerVerticesValid

hnswParams

    recordCachingParams

    enableVectorIntegrityCheck

indexUpdateParams

    recordCachingParams

    enableVectorIntegrityCheck

HnswBatchingParams

    maxReindexRecords

    reindexInterval

Changes the type of…

HnswCachingParams

    expiry from uint64 to int64 (this BREAKS the grpc protocol making this api version incompatible with older clients and older servers)

Renames (these are all BREAKING changes for applications consuming the go client)

HnswIndexUpdate

    cachingParams → indexCachingParams

HnswParams

    cachingParams → indexCachingParams

HnswBatchingParams

    maxRecords → maxIndexRecords

    interval → indexInterval

Makes Optional (these are all BREAKING changes for applications consuming the go client)

PutRequest

    WriteType

ProjectionFilter

    ProjectionType

IndexDefinition

    IndexType

    VectorDistanceMetric

@dwelch-spike dwelch-spike marked this pull request as draft October 15, 2024 20:52
@dwelch-spike dwelch-spike self-assigned this Oct 15, 2024
@dwelch-spike dwelch-spike marked this pull request as ready for review October 17, 2024 02:55
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.08%. Comparing base (e6d6218) to head (4db9cb3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   92.57%   93.08%   +0.50%     
==========================================
  Files           7        7              
  Lines        2007     2010       +3     
==========================================
+ Hits         1858     1871      +13     
+ Misses        116      109       -7     
+ Partials       33       30       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwelch-spike dwelch-spike marked this pull request as draft October 17, 2024 16:17
@dwelch-spike dwelch-spike changed the title vec-379 use avs 0.11.0 proto files vec-379 Support AVS 0.11.x Oct 22, 2024
@dwelch-spike dwelch-spike marked this pull request as ready for review October 22, 2024 21:00
Copy link

@rahul-aerospike rahul-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we are committing generated proto files to the repository? Since this is a compiled language, I would assume it's possible to generate the proto files during the artifact generation process, rather than committing them. @dwelch-spike

@dwelch-spike
Copy link
Contributor Author

dwelch-spike commented Oct 24, 2024

Is there a reason we are committing generated proto files to the repository? Since this is a compiled language, I would assume it's possible to generate the proto files during the artifact generation process, rather than committing them. @dwelch-spike

@rahul-aerospike It's so that consumers of this library can use it more easily. In Golang, libs aren't built into artifacts like wheels in Python, instead source code is pulled in directly with the go get command. With the generated files in the repo, the code will work out of the box

@rahul-aerospike
Copy link

@dwelch-spike Got it, that makes sense. In a future release, it might be better to organize the proto files into a separate directory from the generated files.

Copy link

@rahul-aerospike rahul-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every thing else looks good to me. Please wait for yevgeny's approval before merging, if possible.

@dwelch-spike dwelch-spike merged commit 4553b2b into main Oct 25, 2024
4 checks passed
@dwelch-spike dwelch-spike deleted the vec-379 branch October 25, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants