-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vec-379 Support AVS 0.11.x #16
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 92.57% 93.08% +0.50%
==========================================
Files 7 7
Lines 2007 2010 +3
==========================================
+ Hits 1858 1871 +13
+ Misses 116 109 -7
+ Partials 33 30 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we are committing generated proto files to the repository? Since this is a compiled language, I would assume it's possible to generate the proto files during the artifact generation process, rather than committing them. @dwelch-spike
@rahul-aerospike It's so that consumers of this library can use it more easily. In Golang, libs aren't built into artifacts like wheels in Python, instead source code is pulled in directly with the |
@dwelch-spike Got it, that makes sense. In a future release, it might be better to organize the proto files into a separate directory from the generated files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every thing else looks good to me. Please wait for yevgeny's approval before merging, if possible.
Summary of proto changes and their implications…
Adds…
Changes the type of…
Renames (these are all BREAKING changes for applications consuming the go client)
Makes Optional (these are all BREAKING changes for applications consuming the go client)