cleanup

aerospike · Oct 8, 2023 · 13600ea · 13600ea
1 parent 223c9ab
commit 13600ea
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/main/java/org/springframework/data/aerospike/core/AerospikeTemplate.java b/src/main/java/org/springframework/data/aerospike/core/AerospikeTemplate.java
@@ -304,11 +304,10 @@ public <T> void insertAll(Iterable<? extends T> documents) {
         documents.forEach(document -> batchWriteDataList.add(getBatchWriteForInsert(document)));
 
         List<BatchRecord> batchWriteRecords = batchWriteDataList.stream().map(BatchWriteData::batchRecord).toList();
-        RuntimeException re = null;
         try {
             client.operate(null, batchWriteRecords);
         } catch (AerospikeException e) {
-            re = translateError(e);
+            throw translateError(e);
         }
 
         checkForErrorsAndUpdateVersion(batchWriteDataList, batchWriteRecords, "insert");
@@ -361,11 +360,10 @@ public <T> void updateAll(Iterable<T> documents) {
         documents.forEach(document -> batchWriteDataList.add(getBatchWriteForUpdate(document)));
 
         List<BatchRecord> batchWriteRecords = batchWriteDataList.stream().map(BatchWriteData::batchRecord).toList();
-        RuntimeException re = null;
         try {
             client.operate(null, batchWriteRecords);
         } catch (AerospikeException e) {
-            re = translateError(e);
+            throw translateError(e);
         }
 
         checkForErrorsAndUpdateVersion(batchWriteDataList, batchWriteRecords, "update");

diff --git a/src/main/java/org/springframework/data/aerospike/core/BaseAerospikeTemplate.java b/src/main/java/org/springframework/data/aerospike/core/BaseAerospikeTemplate.java
@@ -425,5 +425,4 @@ public <T> BatchWriteData<T> getBatchWriteForUpdate(T document) {
     protected boolean batchRecordFailed(BatchRecord batchRecord) {
         return batchRecord.resultCode != ResultCode.OK || batchRecord.record == null;
     }
-
 }
diff --git a/...st/java/org/springframework/data/aerospike/utility/AdditionalAerospikeTestOperations.java b/...st/java/org/springframework/data/aerospike/utility/AdditionalAerospikeTestOperations.java
@@ -1,5 +1,6 @@
 package org.springframework.data.aerospike.utility;
 
+import com.aerospike.client.AerospikeException;
 import com.aerospike.client.Bin;
 import com.aerospike.client.IAerospikeClient;
 import com.aerospike.client.Key;
@@ -16,7 +17,6 @@
 import lombok.SneakyThrows;
 import lombok.Value;
 import org.awaitility.Awaitility;
-import org.springframework.dao.RecoverableDataAccessException;
 import org.springframework.data.aerospike.core.WritePolicyBuilder;
 import org.springframework.data.aerospike.index.IndexesCacheRefresher;
 import org.springframework.data.aerospike.query.cache.IndexInfoParser;
@@ -167,7 +167,7 @@ public <T> void deleteAll(AerospikeRepository<T, ?> repository, Collection<T> en
         if (ServerVersionUtils.isBatchWriteSupported(client)) {
             try {
                 repository.deleteAll(entities);
-            } catch (RecoverableDataAccessException ignored) {
+            } catch (AerospikeException.BatchRecordArray ignored) {
                 // KEY_NOT_FOUND ResultCode causes exception if there are no entities
             }
         } else {
-Original file line number
+Diff line change
@@ Expand Up @@
         protected boolean batchRecordFailed(BatchRecord batchRecord) {
             return batchRecord.resultCode != ResultCode.OK || batchRecord.record == null;
         }
     }