FMWK-196 Index Cardinality #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reugn
reviewed
Nov 14, 2023
|
|
||
| // If index with min bin values ratio found, set filter with the matching qualifier | ||
| if (minBinValuesRatioQualifier != null) { | ||
| Filter filter = minBinValuesRatioQualifier.setQueryAsFilter(); |
There was a problem hiding this comment.
The setFilterFromSingleQualifier method can be reused here.
Comment on lines
153
to
156
| if (minBinValuesRatio.isPresent()) { | ||
| return minBinValuesRatio.get().getBinValuesRatio(); | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
refactor to:
return minBinValuesRatio.map(Index::getBinValuesRatio).orElse(0);| private final IndexCollectionType indexCollectionType; | ||
| private final CTX[] ctx; | ||
| @Setter | ||
| private Integer binValuesRatio; |
| @@ -37,6 +44,8 @@ public class InternalIndexOperations { | |||
|
|
|||
| private final IndexInfoParser indexInfoParser; | |||
|
|
|||
| private final Logger log = LoggerFactory.getLogger(InternalIndexOperations.class); | |||
There was a problem hiding this comment.
Use the @Slf4j annotation instead.
| int currBinValuesRatio = getMinBinValuesRatioForQualifier(stmt, innerQualifier); | ||
| // Compare the cardinality of each qualifier and select the qualifier that has the index with | ||
| // the lowest bin values ratio | ||
| if (currBinValuesRatio < minBinValuesRatio && currBinValuesRatio != 0) { |
There was a problem hiding this comment.
I would move currBinValuesRatio != 0 to be first in this statement.
| .collect(Collectors.toMap(t -> t.get(0), t -> t.get(1))) | ||
| .get("entries_per_bval")); | ||
| } catch (Exception e) { | ||
| log.warn("Failed to fetch secondary index %s cardinality".formatted(indexName), e); |
There was a problem hiding this comment.
Use
log.warn("Failed to fetch secondary index {} cardinality", indexName, e);instead.
2. Reuse methods, avoid code duplication
…plify conditions
reugn
approved these changes
Nov 14, 2023
agrgr
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.