FMWK-265 Prepare release 4.6.0 #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roimenashe
reviewed
Dec 6, 2023
pom.xml
Outdated
| @@ -26,20 +26,20 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <springdata.commons>3.1.2</springdata.commons> | |||
| <springdata.keyvalue>3.1.2</springdata.keyvalue> | |||
| <spring-cloud-starter-bootstrap>4.0.3</spring-cloud-starter-bootstrap> | |||
| <spring-cloud-starter-bootstrap>4.0.4</spring-cloud-starter-bootstrap> | |||
| <spring-boot-starter-test>3.1.0</spring-boot-starter-test> | |||
There was a problem hiding this comment.
There is new releases available for spring-boot-start-test, I assume 3.2.0 is for the new Spring Boot 3.2 but we can still bump it to 3.1.6 (latest of 3.1.x) if we keep Spring Boot at 3.1
There was a problem hiding this comment.
Same thing for commons and keyvalue? bump to 3.1.6 if possible and if we are not waiting for 3.2.
roimenashe
reviewed
Dec 6, 2023
pom.xml
Outdated
| <aerospike-client>7.1.0</aerospike-client> | ||
| <aerospike-reactor-client>7.0.0</aerospike-reactor-client> | ||
| <aerospike-client>7.2.0</aerospike-client> | ||
| <aerospike-reactor-client>7.1.0</aerospike-reactor-client> | ||
| <reactor-test>3.5.7</reactor-test> |
There was a problem hiding this comment.
Latest is 3.6.0 but there is also 3.5.12 if 3.6 presents a breaking change that we don't want to include
roimenashe
reviewed
Dec 6, 2023
pom.xml
Outdated
| <awaitility>4.2.0</awaitility> | ||
| <logback.test>1.4.11</logback.test> | ||
| <logback.test>1.4.12</logback.test> |
There was a problem hiding this comment.
I think the latest version of logback.test is 1.4.14
…into FMWK-265-prepare-release-4.6.0
reugn
reviewed
Dec 10, 2023
.github/workflows/build.yml
Outdated
| @@ -12,7 +12,7 @@ jobs: | |||
| steps: | |||
| # Checkout repo using https://github.com/marketplace/actions/checkout | |||
| - name: Checkout | |||
| uses: actions/checkout@v3 | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Set up JDK 17 | |||
| uses: actions/setup-java@v3 | |||
| @@ -6,7 +6,7 @@ jobs: | |||
| publish: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/checkout@v4 | |||
| - name: Import GPG Key | |||
| uses: crazy-max/ghaction-import-gpg@v5 | |||
roimenashe
approved these changes
Dec 10, 2023
…ase-4.6.0 # Conflicts: # src/main/asciidoc/reference/aerospike.adoc # src/main/asciidoc/reference/getting-started.adoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.