FMWK-438 Add tests and javadocs for comparing Collections #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reugn
approved these changes
May 12, 2024
Comment on lines
95
to
97
| if (queryParameters.stream().anyMatch(param -> !(param instanceof List<?>))) { | ||
| throw new IllegalArgumentException(queryPartDescription + ": only Lists can be compared"); | ||
| } |
There was a problem hiding this comment.
Consider extracting to a util method and reusing it.
| private static boolean propertyTypeAndFirstParamAssignableToNumber(Class<?> propertyType, | ||
| List<Object> queryParameters) { | ||
| return queryParameters != null | ||
| && queryParameters.size() > 0 |
agrgr
changed the title
|
@agrgr As discussed, removing the support for collections comparison other than list (e.g. sets) is problematic, it introduces a breaking change and it also removes a useful feature. We will talk about it tomorrow (and cover additional sets comparison scenarios such as GT, LE etc...) |
Changing the PR as discussed. |
agrgr
changed the title
roimenashe
reviewed
May 15, 2024
| PriorityQueue<Integer> queueToCompareWith = new PriorityQueue<>(Set.of(3, 1, 2, 4, 0)); | ||
| List<Person> persons4 = repository.findByIntSetGreaterThan(queueToCompareWith); | ||
| assertThat(persons4).contains(dave); | ||
|
|
roimenashe
reviewed
May 15, 2024
| PriorityQueue<Integer> queueToCompareWith = new PriorityQueue<>(Set.of(3, 1, 2, 4, 0)); | ||
| List<Person> persons4 = repository.findByIntSetGreaterThanEqual(queueToCompareWith); | ||
| assertThat(persons4).contains(dave); | ||
|
|
roimenashe
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update repository queries validation to only support Lists with comparison operators instead of Collection