FMWK-443 Add configuration flag writeSortedMaps #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roimenashe
reviewed
May 26, 2024
| @@ -157,7 +159,12 @@ private void convertToAerospikeWriteData(Object source, AerospikeWriteData data) | |||
|
|
|||
| private Map<String, Object> convertProperties(TypeInformation<?> type, AerospikePersistentEntity<?> entity, | |||
| ConvertingPropertyAccessor<?> accessor, boolean isCustomType) { | |||
| Map<String, Object> target = new TreeMap<>(); | |||
| Map<String, Object> target; | |||
| if (!settings.isWriteTreeMaps()) { | |||
There was a problem hiding this comment.
simpler to check isWriteTreeMaps and set target as TreeMap, otherwise use HashMap (follow the condition, no need for !
roimenashe
reviewed
May 26, 2024
| @@ -234,7 +241,14 @@ protected Map<Object, Object> convertMap(final Map<Object, Object> source, final | |||
| Assert.notNull(source, "Given map must not be null!"); | |||
| Assert.notNull(type, "Given type must not be null!"); | |||
|
|
|||
| return source.entrySet().stream().collect(TreeMap::new, (m, e) -> { | |||
| Supplier<Map<Object, Object>> mapSupplier; | |||
| if (!settings.isWriteTreeMaps()) { | |||
There was a problem hiding this comment.
Same here:
simpler to check isWriteTreeMaps and set target as TreeMap, otherwise use HashMap (follow the condition, no need for !
reugn
reviewed
May 27, 2024
| @@ -37,4 +37,6 @@ public class AerospikeDataSettings { | |||
| // Define how @Id fields (primary keys) and Map keys are stored: false - always as String, | |||
| // true - preserve original type if supported | |||
| boolean keepOriginalKeyTypes = false; | |||
| // Define how Maps are written: true - as TreeMaps (default), false - as HashMaps | |||
| boolean writeTreeMaps = true; | |||
There was a problem hiding this comment.
Consider renaming to useSortedMap.
Comment on lines
162
to
167
| Map<String, Object> target; | ||
| if (settings.isWriteTreeMaps()) { | ||
| target = new TreeMap<>(); | ||
| } else { | ||
| target = new HashMap<>(); | ||
| } |
There was a problem hiding this comment.
Consider using the ternary operator.
Comment on lines
244
to
249
| Supplier<Map<Object, Object>> mapSupplier; | ||
| if (settings.isWriteTreeMaps()) { | ||
| mapSupplier = TreeMap::new; | ||
| } else { | ||
| mapSupplier = HashMap::new; | ||
| } |
There was a problem hiding this comment.
Consider using the ternary operator.
reugn
changed the title
reugn
approved these changes
May 28, 2024
roimenashe
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.