FMWK-425 Document FilterOperations #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrgr
commented
May 28, 2024
agrgr
commented
- Document FilterOperations
- Update logging
roimenashe
reviewed
May 29, 2024
| @@ -454,6 +507,10 @@ public Filter sIndexFilter(Map<QualifierKey, Object> qualifierMap) { | |||
| return null; // not supported | |||
| } | |||
| }, | |||
| /** | |||
| * For use in queries "find records where Map key <...> has value equal to a given object". The Map can be a whole | |||
| * bin or part of it (nested inside one or more Lists or other Maps). Maps in the database represent also POJOs. | |||
There was a problem hiding this comment.
Maps in the database represent also POJOs.
I think its not clear enough, I would change that to something like "Maps in Aerospike database can represent a Map or an entire POJO".
The same phrase is used many times in this file.
roimenashe
reviewed
May 29, 2024
| @@ -140,7 +140,7 @@ private boolean isIndexedBin(Statement stmt, Qualifier qualifier) { | |||
| } | |||
|
|
|||
| if (log.isDebugEnabled() && hasField) { | |||
| log.debug("Query #{}, bin {}.{}.{} has secondary index: {}", | |||
| log.debug("Qualifier #{}, bin {}.{}.{} has secondary index: {}", | |||
There was a problem hiding this comment.
Does printing Qualifier Hashcode has any meaning from the user's perspective? does it help us in debugging?
There was a problem hiding this comment.
Hashcode serves as a unique identifier to help find other log messages related to the qualifier.
roimenashe
approved these changes
May 29, 2024
reugn
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.