FMWK-451 Find by "not equals" doesn't return entities with nonexistent path #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrgr
commented
May 29, 2024
•
agrgr
commented
- Support returning entities with nonexistent path for NOTEQ
reugn
approved these changes
May 29, 2024
roimenashe
reviewed
May 29, 2024
| @@ -64,6 +64,10 @@ public QueryEngine queryEngine(IAerospikeClient aerospikeClient, | |||
| long queryMaxRecords = settings.getDataSettings().getQueryMaxRecords(); | |||
| log.debug("AerospikeDataSettings.queryMaxRecords: {}", queryMaxRecords); | |||
| queryEngine.setQueryMaxRecords(queryMaxRecords); | |||
| if (!settings.getDataSettings().isWriteSortedMaps()) { | |||
| log.debug("AerospikeDataSettings.writeSortedMaps is set to false, " + | |||
There was a problem hiding this comment.
I would even change the severity of this to INFO instead of DEBUG, since it is only printed once on initialization and is quite important
roimenashe
reviewed
May 29, 2024
| @@ -64,6 +64,10 @@ public QueryEngine queryEngine(IAerospikeClient aerospikeClient, | |||
| long queryMaxRecords = settings.getDataSettings().getQueryMaxRecords(); | |||
| log.debug("AerospikeDataSettings.queryMaxRecords: {}", queryMaxRecords); | |||
| queryEngine.setQueryMaxRecords(queryMaxRecords); | |||
| if (!settings.getDataSettings().isWriteSortedMaps()) { | |||
| log.debug("AerospikeDataSettings.writeSortedMaps is set to false, " + | |||
| "Maps and POJOs will be written as unsorted Maps (decrease in performance compared with sorted Maps)"); | |||
There was a problem hiding this comment.
Is performance decrease the only outcome? what happens if you compare a given sorted map to a non-sorted map in Aerospike db? it will return false if the order doesn't match right?
There was a problem hiding this comment.
Maps comparison is not supported for unsorted Maps, as far as I remember. So for older versions like 3.5.0 it was not supported
There was a problem hiding this comment.
So I would remove this comment about performance decrease, this isn't the only outcome it will affect comparison in general as well
roimenashe
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.