Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-617 Update documentation #800

Merged
merged 6 commits into from
Dec 24, 2024
Merged

FMWK-617 Update documentation #800

merged 6 commits into from
Dec 24, 2024

Conversation

agrgr
Copy link

@agrgr agrgr commented Dec 12, 2024

No description provided.

@agrgr agrgr requested a review from reugn December 12, 2024 15:26
@agrgr agrgr marked this pull request as ready for review December 12, 2024 15:32
@reugn reugn requested a review from rbotzer December 12, 2024 17:06
README.adoc Outdated Show resolved Hide resolved
Comment on lines +151 to +152
of the `AbstractAerospikeDataConfiguration` class or define `spring.aerospike.hosts` and
`spring.data.aerospike.namespace` in `application.properties` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see documentation that talks about this change. Will that be discussed in the release notes and other markdown pages in the repo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbotzer The configuration is described in configuration.adoc file, it lists all properties

Copy link
Member

@rbotzer rbotzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of small suggestions, but I'm pre-approving it.

@agrgr agrgr merged commit eaf2082 into main Dec 24, 2024
8 checks passed
@agrgr agrgr deleted the FMWK-617-update-documentation branch December 24, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants