Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support environments other than bevy_winit #45

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

soqb
Copy link

@soqb soqb commented Aug 14, 2023

when writing a tui with bevy, i found myself reaching for bevy_framepace but discovered it relies on bevy_winit in all cases.

this PR gates the refresh rate fetching logic behind a new "window" feature so that the plugin's main algorithm can be used outside of a windowed environment.

for Limiter::Auto, when the feature is not enabled, i chose 15fps as the default, which i think is reasonable for most tuis.

@aevyrie
Copy link
Owner

aevyrie commented Oct 23, 2023

It seems strange to me to bake in defaults for TUI in a framepacing plugin. I'm not sure what the point of this crate is for that use case, it seems like you would be better off simply running a fixed rate or custom runner.

@stewartadam
Copy link

I would also find this useful to support outside of winit, for my use case I'm using Bevy and its ECS for a simulation that requires precise timing, but there's no graphical output. The entities maintain state in the ECS that is pushed out to hardware via serial or ethernet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants