build: drop support for python 3.8 (#572)

* drop python 3.8

* collections.abc.Callable instead of typing Callable

---------

Co-authored-by: Daniel G. Krakowczyk <[email protected]>

.github/workflows/tests.yml

@@ -19,13 +19,10 @@ jobs:
           - ubuntu-latest
           - windows-latest
         tox_env:
-          - py38
           - py39
           - py310
           - py311
         include:
-          - tox_env: py38
-            python: "3.8"
           - tox_env: py39
             python: "3.9"
           - tox_env: py310
@@ -104,7 +101,7 @@ jobs:
       - name: Install base python for tox
         uses: actions/setup-python@v4
         with:
-          python-version: "3.8"
+          python-version: "3.9"
       - name: Install tox
         run: python -m pip install tox
       - name: Setup test environment

.pre-commit-config.yaml

@@ -12,17 +12,16 @@ repos:
     rev: v3.1.0
     hooks:
     -   id: add-trailing-comma
-        args: [--py36-plus]
 -   repo: https://github.com/asottile/pyupgrade
     rev: v3.13.0
     hooks:
     -   id: pyupgrade
-        args: [--py38-plus]
+        args: [--py39-plus]
 -   repo: https://github.com/asottile/reorder-python-imports
     rev: v3.11.0
     hooks:
     -   id: reorder-python-imports
-        args: [--application-directories=src, --py38-plus]
+        args: [--application-directories=src, --py39-plus]
 -   repo: https://github.com/asottile/reorder-python-imports
     rev: v3.11.0
     hooks:
@@ -62,7 +61,7 @@ repos:
     -   id: nbqa-isort
         args: ["--float-to-top"]
     -   id: nbqa-pyupgrade
-        args: ["--py38-plus"]
+        args: ["--py39-plus"]
 -   repo: https://github.com/pre-commit/mirrors-mypy
     rev: v1.5.1
     hooks:

CONTRIBUTING.md

@@ -157,9 +157,9 @@ If you add a new feature, please also include appropriate tests to verify its in
 functionality. We try to keep our code coverage close to 100%.
 
 It is possible to limit the scope of testing to specific environments and files. For example, to
-only test event related functionality using the Python 3.8 environment use:
+only test event related functionality using the Python 3.9 environment use:
 ```bash
-tox -e py38 tests/events
+tox -e py39 tests/events
 ```
 
 

pylintrc

@@ -54,7 +54,7 @@ unsafe-load-any-extension=no
 extension-pkg-allow-list=
 
 # Minimum supported python version
-py-version = 3.8.0
+py-version = 3.9.0
 
 # Control the amount of potential inferred values when inferring a single
 # object. This can help the performance when dealing with large functions or
@@ -520,7 +520,7 @@ overgeneral-exceptions=builtins.Exception
 # **exclusively** for type checking of an application, you're probably fine.
 # For libraries, evaluate if some users what to access the type hints at
 # runtime first, e.g., through ``typing.get_type_hints``. Applies to Python
-# versions 3.8 - 3.10
+# versions 3.9 - 3.11
 runtime-typing = no
 
 

pyproject.toml

@@ -11,7 +11,7 @@ build-backend = "setuptools.build_meta"
 name = "pymovements"
 description = "A python package for processing eye movement data"
 readme = "README.md"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 license = {text = "MIT License"}
 maintainers = [
   {name = "Daniel Krakowczyk", email = "[email protected]"}
@@ -24,7 +24,6 @@ classifiers = [
   "Operating System :: Microsoft :: Windows",
   "Operating System :: POSIX :: Linux",
   "Operating System :: OS Independent",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",

src/pymovements/dataset/dataset_library.py

@@ -20,7 +20,6 @@
 """DatasetLibrary module."""
 from __future__ import annotations
 
-from typing import Type
 from typing import TypeVar
 
 from pymovements.dataset.dataset_definition import DatasetDefinition
@@ -60,7 +59,7 @@ def get(cls, name: str) -> type[DatasetDefinition]:
         return cls.definitions[name]
 
 
-DatsetDefinitionClass = TypeVar('DatsetDefinitionClass', bound=Type[DatasetDefinition])
+DatsetDefinitionClass = TypeVar('DatsetDefinitionClass', bound=type[DatasetDefinition])
 
 
 def register_dataset(cls: DatsetDefinitionClass) -> DatsetDefinitionClass:

src/pymovements/gaze/transforms.py

@@ -20,9 +20,9 @@
 """Module for py:func:`pymovements.gaze.transforms."""
 from __future__ import annotations
 
+from collections.abc import Callable
 from functools import partial
 from typing import Any
-from typing import Callable
 from typing import TypeVar
 
 import numpy as np

src/pymovements/plotting/traceplot.py

@@ -21,10 +21,8 @@
 from __future__ import annotations
 
 import sys
-from typing import Dict
+from collections.abc import Sequence
 from typing import Literal
-from typing import Sequence
-from typing import Tuple
 
 import matplotlib.colors
 import matplotlib.pyplot as plt
@@ -42,8 +40,8 @@
 if 'pytest' in sys.modules:  # pragma: no cover
     matplotlib.use('Agg')
 
-LinearSegmentedColormapType: TypeAlias = Dict[
-    Literal['red', 'green', 'blue', 'alpha'], Sequence[Tuple[float, ...]],
+LinearSegmentedColormapType: TypeAlias = dict[
+    Literal['red', 'green', 'blue', 'alpha'], Sequence[tuple[float, ...]],
 ]
 
 DEFAULT_SEGMENTDATA: LinearSegmentedColormapType = {

tox.ini

@@ -2,7 +2,6 @@
 isolated_build = True
 skip_missing_interpreters = True
 envlist =
-    py38
     py39
     py310
     py311