Skip to content

Commit

Permalink
always test 3.8 and 3.11, typealias not a thing yet
Browse files Browse the repository at this point in the history
  • Loading branch information
SiQube committed Sep 15, 2023
1 parent 68a15e7 commit bc1af47
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ repos:
rev: v1.5.1
hooks:
- id: mypy
additional_dependencies: [types-all]
additional_dependencies: [types-all, pandas-stubs, types-tqdm]
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
hooks:
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ check_untyped_defs = true
disallow_incomplete_defs = true
disallow_untyped_defs = true
warn_redundant_casts = true
warn_unused_ignores = true

[[tool.mypy.overrides]]
module = "scipy.*"
Expand Down
2 changes: 1 addition & 1 deletion src/pymovements/plotting/main_sequence_plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def main_sequence_plot(
alpha=alpha,
s=marker_size,
marker=marker,
# XXX to handle after https://github.com/pydata/xarray/pull/8030 is merged
# to handle after https://github.com/pydata/xarray/pull/8030 is merged
**kwargs, # type: ignore
)

Expand Down
15 changes: 10 additions & 5 deletions src/pymovements/plotting/traceplot.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
from __future__ import annotations

import sys
from collections.abc import Sequence
from typing import Literal
from typing import Sequence
from typing import TypeAlias

import matplotlib.colors
import matplotlib.pyplot as plt
Expand All @@ -40,8 +39,11 @@
if 'pytest' in sys.modules: # pragma: no cover
matplotlib.use('Agg')

LinearSegmentedColormapType: TypeAlias = dict[
Literal['red', 'green', 'blue', 'alpha'], Sequence[tuple[float, ...]],
LinearSegmentedColormapType = dict[
Literal[
'red', 'green',
'blue', 'alpha',
], Sequence[tuple[float, ...]],
]

DEFAULT_SEGMENTDATA: LinearSegmentedColormapType = {
Expand Down Expand Up @@ -201,7 +203,10 @@ def traceplot(
elif isinstance(cmap_norm, str):
# pylint: disable=protected-access

if (scale_class := matplotlib.scale._scale_mapping.get(cmap_norm, None)) is None:
# to handle after https://github.com/pydata/xarray/pull/8030 is merged
if (
scale_class := matplotlib.scale._scale_mapping.get(cmap_norm, None) # type: ignore
) is None:
raise ValueError(f'cmap_norm string {cmap_norm} is not supported')

norm_class = matplotlib.colors.make_norm_from_scale(scale_class)
Expand Down

0 comments on commit bc1af47

Please sign in to comment.