Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid type ambivalence in Experiment.screen and Experiment.eyetracker #891

Closed
5 tasks done
saeub opened this issue Nov 9, 2024 · 2 comments · Fixed by #1010
Closed
5 tasks done

Avoid type ambivalence in Experiment.screen and Experiment.eyetracker #891

saeub opened this issue Nov 9, 2024 · 2 comments · Fixed by #1010
Labels
bug Something isn't working good first issue Good for newcomers nonessential nice to have

Comments

@saeub
Copy link
Collaborator

saeub commented Nov 9, 2024

Current Behavior

At least Experiment.eyetracker can be None (if sampling_rate is passed in Experiment.__init__()). Experiment.screen should always be of type Screen, unless it is tampered with after initialization.

Details: #884 (comment)

Expected Behavior

Experiment.screen should always be of type Screen, Experiment.eyetracker should alwys be of type EyeTracker.

Minimum acceptance criteria

@saeub saeub added the bug Something isn't working label Nov 9, 2024
@dkrako dkrako added good first issue Good for newcomers nonessential nice to have labels Dec 11, 2024
@dkrako
Copy link
Contributor

dkrako commented Dec 11, 2024

I labeled it nonessential as it's only protecting the user against themselves. feel free to raise the priority in case

@dkrako dkrako linked a pull request Mar 7, 2025 that will close this issue
@dkrako
Copy link
Contributor

dkrako commented Mar 7, 2025

I marked #1010 to resolve this issue, as the main issue lies in the type ambivalence of the eyetracker field.

I created #1011 as a followup for making attributes tamper-free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers nonessential nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@dkrako @saeub and others