-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve Experiment
class
#1010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- restricts eyetracker argument to keyword-only - implements equality operator - resolves type ambivalence of eyetracker field - adds screen argument
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 78
Lines 3571 3560 -11
Branches 631 629 -2
=========================================
- Hits 3571 3560 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
5 tasks
dkrako
commented
Mar 7, 2025
SiQube
reviewed
Mar 7, 2025
SiQube
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 (not really a) Breaking Change
Restricts eyetracker argument to keyword-only. As
sampling_rate
andeyetracker
already was mutually exclusive, I don't see how this would break any existing workflow.Description
DatasetDefinition
asExperiment
now allows for empty initDatasetDefinitions
This PR now also allows for full equality comparisons between
DatasetDefinition
instances.Blocked by #1008