Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Experiment class #1010

Merged
merged 21 commits into from
Mar 8, 2025
Merged

feat: improve Experiment class #1010

merged 21 commits into from
Mar 8, 2025

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Mar 7, 2025

💥 (not really a) Breaking Change

Restricts eyetracker argument to keyword-only. As sampling_rate and eyetracker already was mutually exclusive, I don't see how this would break any existing workflow.

Description

This PR now also allows for full equality comparisons between DatasetDefinition instances.

Blocked by #1008

@github-actions github-actions bot added the enhancement New feature or request label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3a54708) to head (9bb705b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1010   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           78        78           
  Lines         3571      3560   -11     
  Branches       631       629    -2     
=========================================
- Hits          3571      3560   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkrako dkrako marked this pull request as ready for review March 7, 2025 14:02
@dkrako dkrako requested review from SiQube and prassepaul as code owners March 7, 2025 14:02
@dkrako dkrako linked an issue Mar 7, 2025 that may be closed by this pull request
5 tasks
@dkrako dkrako enabled auto-merge (squash) March 7, 2025 14:37
Copy link
Member

@SiQube SiQube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkrako dkrako merged commit b893eb7 into main Mar 8, 2025
25 checks passed
@dkrako dkrako deleted the feat/improved-experiment-class branch March 8, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid type ambivalence in Experiment.screen and Experiment.eyetracker
2 participants