Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GazeDataFrame.detect() #511

Merged
merged 1 commit into from
Sep 15, 2023
Merged

feat: Add GazeDataFrame.detect() #511

merged 1 commit into from
Sep 15, 2023

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Sep 8, 2023

Description

This is a major step towards a self-contained Gaze class.
We now do not need a Dataset object anymore to run event detection algorithms.

Depends on #553 and #554

Implemented changes

  • implement GazeDataFrame.detect()
  • implement gazeDataFrame._infer_eye_components()
  • refactored some private functions in gazeframe module to private methods
  • Reuse GazeDataFrame.detect() in Dataset.detect()

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Migrated all detection tests to call GazeDataFrame.detect() (old detection tests are left untouched)
  • Tested several eye configurations

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (097cbbb) 100.00% compared to head (b3d1fbd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #511   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2139      2152   +13     
  Branches       521       532   +11     
=========================================
+ Hits          2139      2152   +13     
Files Changed Coverage Δ
src/pymovements/dataset/dataset_files.py 100.00% <ø> (ø)
src/pymovements/plotting/traceplot.py 100.00% <ø> (ø)
src/pymovements/__init__.py 100.00% <100.00%> (ø)
src/pymovements/dataset/dataset.py 100.00% <100.00%> (ø)
src/pymovements/events/detection/_ivt.py 100.00% <100.00%> (ø)
src/pymovements/events/processing.py 100.00% <100.00%> (ø)
src/pymovements/gaze/gaze_dataframe.py 100.00% <100.00%> (ø)
src/pymovements/gaze/integration.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako added this to the Sprint 17 milestone Sep 9, 2023
@dkrako dkrako self-assigned this Sep 9, 2023
@dkrako dkrako force-pushed the feature/gaze-detect branch 2 times, most recently from b8f6db2 to 2cfc0cd Compare September 14, 2023 12:18
@dkrako dkrako marked this pull request as ready for review September 14, 2023 15:09
@dkrako dkrako force-pushed the feature/gaze-detect branch from 61f3773 to b3d1fbd Compare September 14, 2023 15:11
@dkrako dkrako merged commit 9a10c04 into main Sep 15, 2023
20 checks passed
@dkrako dkrako deleted the feature/gaze-detect branch September 15, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants