Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add kwargs for explicit data passing in gaze.from_numpy() #513

Merged
merged 12 commits into from
Sep 12, 2023

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Sep 8, 2023

Description

Adds new keyword arguments to pass time, position, velocity numpy arrays as keyword arguments to pm.gaze.from_numpy()

Fixes issue #501

Implemented changes

  • Make data and schema argument optional
  • Add time, pixel, position, velocity, acceleration arguments

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change is or requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test full specification with schema
  • Test full specification with explicit lists
  • Test all None

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (380df1e) 100.00% compared to head (217b1f0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #513   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2081      2117   +36     
  Branches       505       511    +6     
=========================================
+ Hits          2081      2117   +36     
Files Changed Coverage Δ
src/pymovements/gaze/integration.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako linked an issue Sep 8, 2023 that may be closed by this pull request
@dkrako dkrako changed the title feat: Add support for explicit column passing in gaze.from_numpy() feat: Add kwargs for explicit data passing in gaze.from_numpy() Sep 9, 2023
@dkrako dkrako marked this pull request as ready for review September 9, 2023 12:03
Copy link
Member

@prassepaul prassepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some more comments (can be high-level)...

src/pymovements/gaze/integration.py Outdated Show resolved Hide resolved
@dkrako dkrako self-assigned this Sep 11, 2023
@dkrako dkrako requested a review from prassepaul September 11, 2023 19:33
Copy link
Member

@prassepaul prassepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@dkrako dkrako merged commit 045f6a2 into main Sep 12, 2023
@dkrako dkrako deleted the feature/from-numpy-explicit-columns branch September 12, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve usability of gaze.from_numpy() by explicit array passing
2 participants