-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add kwargs for explicit data passing in gaze.from_numpy() #513
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 2081 2117 +36
Branches 505 511 +6
=========================================
+ Hits 2081 2117 +36
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add some more comments (can be high-level)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
Description
Adds new keyword arguments to pass time, position, velocity numpy arrays as keyword arguments to
pm.gaze.from_numpy()
Fixes issue #501
Implemented changes
data
andschema
argument optionaltime
,pixel
,position
,velocity
,acceleration
argumentsType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
None
Checklist: