Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Infer correct number of components in gaze init #521

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Sep 9, 2023

Description

This PR implements a more robust way of inferring the number of components in a GazeDataFrame.

Fixes issue #514

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Added components checks to existing gaze init tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@dkrako dkrako linked an issue Sep 9, 2023 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e59d0c) 100.00% compared to head (19007d4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #521   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2117      2129   +12     
  Branches       511       516    +5     
=========================================
+ Hits          2117      2129   +12     
Files Changed Coverage Δ
src/pymovements/gaze/gaze_dataframe.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako marked this pull request as ready for review September 11, 2023 19:01
@dkrako dkrako self-assigned this Sep 11, 2023
Copy link
Member

@prassepaul prassepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comment above. maybe we can/should change that?

@dkrako dkrako changed the title fix: Fix incorrect inference of n_components in gaze init fix: Infer correct number of components in gaze init Sep 12, 2023
@dkrako dkrako merged commit 2f7b54c into main Sep 12, 2023
@dkrako dkrako deleted the fix/514-n-components branch September 12, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

n_components won't be filled when initializing GazeDataFrame with nested columns
2 participants