-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Infer correct number of components in gaze init #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 2117 2129 +12
Branches 511 516 +5
=========================================
+ Hits 2117 2129 +12
☔ View full report in Codecov by Sentry. |
prassepaul
reviewed
Sep 12, 2023
prassepaul
requested changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the comment above. maybe we can/should change that?
prassepaul
approved these changes
Sep 12, 2023
dkrako
changed the title
fix: Fix incorrect inference of n_components in gaze init
fix: Infer correct number of components in gaze init
Sep 12, 2023
prassepaul
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a more robust way of inferring the number of components in a GazeDataFrame.
Fixes issue #514
Type of change
How Has This Been Tested?
Checklist: