Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Raise helpful missing column error message for transforms (#542) #542

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Sep 12, 2023

resolves #499 and additionally covers both pix2deg and pos2acc

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2f7b54c) 100.00% compared to head (bd34f2c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #542   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2129      2137    +8     
  Branches       516       521    +5     
=========================================
+ Hits          2129      2137    +8     
Files Changed Coverage Δ
src/pymovements/gaze/gaze_dataframe.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for providing these user-friendly error messages!

I just have some cosmetic change requests, that would improve reading flow.

src/pymovements/gaze/gaze_dataframe.py Outdated Show resolved Hide resolved
src/pymovements/gaze/gaze_dataframe.py Show resolved Hide resolved
src/pymovements/gaze/gaze_dataframe.py Show resolved Hide resolved
@SiQube
Copy link
Member Author

SiQube commented Sep 13, 2023

added the requested changes

Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the work!

@dkrako dkrako merged commit 5240e93 into main Sep 13, 2023
20 checks passed
@dkrako dkrako deleted the transforms-raise-helpful-error-message branch September 13, 2023 12:40
@dkrako dkrako changed the title raise helpful error message for transforms feat: Raise helpful missing column error message for transforms (#542) Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raise helpful error message if pos2vel() is applied without pix2deg()
3 participants