Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pip installation of pylint to CONTRIBUTING.md #556

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Sep 14, 2023

to properly run pre-commit, you need a local installation of pylint -- hence I added it to the CONTRIBUTING.md

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f0b2345) 100.00% compared to head (708bd3a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #556   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2176      2176           
  Branches       536       536           
=========================================
  Hits          2176      2176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for going through the documentation!

@dkrako dkrako changed the title hotfix: add pip installation of pylint to pre-commit linting docs add pip installation of pylint to pre-commit linting Sep 22, 2023
@dkrako dkrako changed the title docs add pip installation of pylint to pre-commit linting docs: add pip installation of pylint to CONTRIBUTING.md Sep 22, 2023
@dkrako dkrako merged commit 0e2cb61 into main Sep 22, 2023
20 checks passed
@dkrako dkrako deleted the hotfix-pylint-contributing branch September 22, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants