Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gaze.from_csv() (#504) #557

Merged
merged 12 commits into from
Sep 22, 2023
Merged

feat: Add gaze.from_csv() (#504) #557

merged 12 commits into from
Sep 22, 2023

Conversation

prassepaul
Copy link
Member

@prassepaul prassepaul commented Sep 15, 2023

Description

Please include a clear and concise description of the change and which issue is fixed.
Please also include excepted improvements, relevant motivation and context.
List any dependencies that are required for this change.

Fixes issue #504

Implemented changes

Insert a description of the changes implemented in the pull request.

  • added from_csv
  • added tests

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • test to load in csv file for monocular and binocular data

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0cb6974) 100.00% compared to head (31a258f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #557   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        49    +1     
  Lines         2152      2164   +12     
  Branches       532       532           
=========================================
+ Hits          2152      2164   +12     
Files Changed Coverage Δ
src/pymovements/gaze/__init__.py 100.00% <100.00%> (ø)
src/pymovements/gaze/io.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako linked an issue Sep 15, 2023 that may be closed by this pull request
3 tasks
Copy link
Member

@SiQube SiQube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

src/pymovements/gaze/io.py Show resolved Hide resolved
@SiQube
Copy link
Member

SiQube commented Sep 19, 2023

great work @prassepaul

@dkrako dkrako changed the title added from_csv (#504) feat: add gaze.from_csv() (#504) Sep 22, 2023
Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot for your work!

@dkrako dkrako changed the title feat: add gaze.from_csv() (#504) feat: Add gaze.from_csv() (#504) Sep 22, 2023
@dkrako dkrako merged commit 4de6d34 into main Sep 22, 2023
@dkrako dkrako deleted the feature/gaze_from_csv branch September 22, 2023 05:45
josephine-funken pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load gaze files with gaze.from_csv()
3 participants