Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GazeDataFrame.apply() #558

Merged
merged 6 commits into from
Sep 22, 2023
Merged

feat: Add GazeDataFrame.apply() #558

merged 6 commits into from
Sep 22, 2023

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Sep 15, 2023

Description

This creates a facade method that can be used for both gaze transformations and event detection.

Implemented changes

  • Add GazeDataFrame.apply()

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Copied contents from three event detection test cases
  • Copied contents from three transformation test cases

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4de6d34) 100.00% compared to head (7372d91) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #558   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2164      2176   +12     
  Branches       532       536    +4     
=========================================
+ Hits          2164      2176   +12     
Files Changed Coverage Δ
src/pymovements/events/detection/_library.py 100.00% <100.00%> (ø)
src/pymovements/gaze/gaze_dataframe.py 100.00% <100.00%> (ø)
src/pymovements/gaze/transforms.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako marked this pull request as ready for review September 15, 2023 12:10
@dkrako dkrako merged commit f0b2345 into main Sep 22, 2023
20 checks passed
@dkrako dkrako deleted the feature/gaze-apply branch September 22, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants