Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add public dataset GazeOnFaces #567

Merged
merged 17 commits into from
Sep 22, 2023
Merged

feat: Add public dataset GazeOnFaces #567

merged 17 commits into from
Sep 22, 2023
+244 −0

Conversation

prassepaul
Copy link
Member

Description

added GazeOnFaces dataset

Fixes issue #

Implemented changes

Insert a description of the changes implemented in the pull request.

  • Added a new dataset: GazeOnFaces

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (93ab678) 100.00% compared to head (f3c5067) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #567   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        50    +1     
  Lines         2176      2200   +24     
  Branches       536       543    +7     
=========================================
+ Hits          2176      2200   +24
Files Changed Coverage Δ
src/pymovements/datasets/__init__.py 100.00% <100.00%> (ø)
src/pymovements/datasets/gaze_on_faces.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dkrako
dkrako requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

please also add the two relevant test cases to https://github.com/aeye-lab/pymovements/blob/main/tests/datasets/datasets_test.py

src/pymovements/datasets/__init__.py Show resolved Hide resolved
src/pymovements/datasets/__init__.py Show resolved Hide resolved
@dkrako dkrako changed the title Dataset gazeonfaces feat: Add public dataset GazeOnFaces Sep 22, 2023
dkrako
dkrako approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot!

@dkrako dkrako merged commit 5e0959f into main Sep 22, 2023
20 checks passed
@dkrako dkrako deleted the dataset-gazeonfaces branch September 22, 2023 07:51
josephine-funken pushed a commit that referenced this pull request Sep 25, 2023
@prassepaul @josephine-funken
feat: Add public dataset GazeOnFaces (#567)
2f4c3cc 
Co-authored-by: prassepaul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiQube SiQube SiQube approved these changes

@dkrako dkrako dkrako approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prassepaul @dkrako @SiQube