Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gaze.from_ipc() #568

Merged
merged 24 commits into from
Sep 22, 2023
Merged

feat: Add gaze.from_ipc() #568

merged 24 commits into from
Sep 22, 2023

Conversation

prassepaul
Copy link
Member

Description

add functionality to read from IPC/feather

Fixes issue #518

Implemented changes

Insert a description of the changes implemented in the pull request.

  • added support for IPC/feather

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (869534f) 100.00% compared to head (8d707a8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2208      2213    +5     
  Branches       545       545           
=========================================
+ Hits          2208      2213    +5     
Files Changed Coverage Δ
src/pymovements/gaze/__init__.py 100.00% <100.00%> (ø)
src/pymovements/gaze/io.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SiQube SiQube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prassepaul prassepaul requested a review from SiQube September 22, 2023 10:56
Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work!

As always, I have to nitpick about some minor details.

src/pymovements/gaze/io.py Outdated Show resolved Hide resolved
src/pymovements/gaze/io.py Outdated Show resolved Hide resolved
src/pymovements/gaze/io.py Outdated Show resolved Hide resolved
src/pymovements/datasets/__init__.py Outdated Show resolved Hide resolved
@prassepaul prassepaul requested a review from dkrako September 22, 2023 16:12
@dkrako dkrako changed the title Feature/feature from ipc feat: Add gaze.from_ipc() Sep 22, 2023
@dkrako dkrako merged commit 4edba55 into main Sep 22, 2023
20 checks passed
@dkrako dkrako deleted the feature/feature-from_ipc branch September 22, 2023 16:25
josephine-funken pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants