Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Test resulting filestructure for utils.archives.extract() #570

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Sep 22, 2023

Description

The extracted files after running utils.archives.extract() were not tested for correctness.

This is a problem for testing #401

Implemented changes

  • Added exptected files and directories to test cases
  • Created new fixture for compressed files (bz2, gz, xz) and test accordingly

Type of change

  • Refactor

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@dkrako dkrako changed the title tests: Test resulting filestructure after calling utils.archives.extract() tests: Test resulting filestructure for utils.archives.extract() Sep 22, 2023
@dkrako dkrako marked this pull request as ready for review September 22, 2023 11:51
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4edba55) 100.00% compared to head (d12c277) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #570   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2213      2213           
  Branches       545       545           
=========================================
  Hits          2213      2213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako merged commit 6927c7c into main Sep 22, 2023
20 checks passed
@dkrako dkrako deleted the chore/refactor-archive-tests branch September 22, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants