feat: Optionally remove single-child top-level directory from extracted archives #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/asottile/pyupgrade: v3.10.1 → v3.11.0](asottile/pyupgrade@v3.10.1...v3.11.0) - [github.com/asottile/reorder-python-imports: v3.10.0 → v3.11.0](asottile/reorder-python-imports@v3.10.0...v3.11.0) - [github.com/asottile/reorder-python-imports: v3.10.0 → v3.11.0](asottile/reorder-python-imports@v3.10.0...v3.11.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: prassepaul <[email protected]>
josephine-funken
requested review from
dkrako,
SiQube and
prassepaul
as code owners
3 tasks
|
@josephine-funken thank you for this great work! there seems to be a merge conflict which needs to be removed first -- if you have any questions how to resolve it feel free to reach out. |
…d-files-if-it-has-only-single-child
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 52 52
Lines 2337 2348 +11
Branches 582 587 +5
=========================================
+ Hits 2337 2348 +11
☔ View full report in Codecov by Sentry. |
|
Added functionality to remove top-level directories to |
dkrako
requested changes
Sep 28, 2023
dkrako
changed the title
…d-files-if-it-has-only-single-child # Conflicts: # tests/unit/utils/archives_test.py
dkrako
approved these changes
Oct 13, 2023
…d-files-if-it-has-only-single-child
dkrako
deleted the
401-remove-top-level-directory-from-extracted-files-if-it-has-only-single-child
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes top-level directories from extracted files if its only child is a directory.
This top-level directory in the archive is unnecessary and creates longer file paths than needed.
Fixes issue #401
Implemented changes
Dataset.extract(),dataset_download.extract_dataset()andutils.archives.extract_archive().Type of change
How Has This Been Tested?
tests/utils/archives_test.test_extract_archive_destination_path_None()test_extract_archive_destination_path_not_None()Checklist: