ci: test for minimum version of dependencies #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 52 52
Lines 2337 2337
Branches 582 582
=========================================
Hits 2337 2337 ☔ View full report in Codecov by Sentry. |
|
took a a lot of binary search iterations until I identified all minimum dependencies, but this should be it. I added the explicit pyopenssl dependency (used by urllib), as there were at least two laptops during my tutorial in kaunas that had very outdated pyopenssl versions and therefore couldn't download any dataset. fixing the minimum version should resolve this problem from now on |
SiQube
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we do not test our minimum versions of dependencies. this lead to errors in the past, where users had old openssl packages installed.
this pr adds a test for our minimum supported versions.