Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update checksum of PoTeC resource file #691

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Feb 22, 2024

The checksum of the PoTeC resource file has changed and thus tox -e integration failed.

I have updated the checksum.

@theDebbister can you confirm that the zip file has changed?
I can see a revision at the beginning of the current month here: https://osf.io/tgd9q

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b097c93) to head (1ad4ae8).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #691   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         2500      2500           
  Branches       633       633           
=========================================
  Hits          2500      2500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiQube
Copy link
Member

SiQube commented Feb 22, 2024

I'll approve but please wait for @theDebbister

Copy link
Member

@theDebbister theDebbister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it has changed. totally forgot to mention it. But the reference and abstract have also changed in the meantime, I will quickly adapt and push this today. After that it's good to merge from my side..

@SiQube
Copy link
Member

SiQube commented Feb 26, 2024

@theDebbister can you also adjust the reference etc. for pymovements

@dkrako dkrako merged commit 53aa819 into main Feb 29, 2024
18 checks passed
@dkrako dkrako deleted the fix/potec-checksum branch February 29, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants