Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove debug print statements in tests #770

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Aug 1, 2024

No description provided.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2cbec93) to head (e120589).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #770   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines         2819      2817    -2     
  Branches       759       759           
=========================================
- Hits          2819      2817    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiQube SiQube requested a review from saeub August 20, 2024 07:09
@saeub
Copy link
Collaborator

saeub commented Aug 22, 2024

Are these possibly also debug print statements?

print(definition.filename_format)
print(curly_to_regex(definition.filename_format))

Copy link
Collaborator

@saeub saeub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@SiQube SiQube enabled auto-merge (squash) August 22, 2024 22:56
@SiQube SiQube merged commit b392b8c into main Aug 22, 2024
21 checks passed
@SiQube SiQube deleted the remove-debug-print-statements branch August 22, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants