Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable fixation only datasets #771

Merged
merged 11 commits into from
Aug 26, 2024
Merged

enable fixation only datasets #771

merged 11 commits into from
Aug 26, 2024

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Aug 5, 2024

eventually resolves #716

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b392b8c) to head (caed462).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #771   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        61    +1     
  Lines         2817      2914   +97     
  Branches       759       779   +20     
=========================================
+ Hits          2817      2914   +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiQube SiQube marked this pull request as ready for review August 17, 2024 19:25
@SiQube
Copy link
Member Author

SiQube commented Aug 17, 2024

for pre-commit ci to pass need to merge #774 first

@SiQube
Copy link
Member Author

SiQube commented Aug 20, 2024

resolves #716

@SiQube SiQube added the enhancement New feature or request label Aug 20, 2024
@SiQube
Copy link
Member Author

SiQube commented Aug 22, 2024

we have to think about integration tests when considering this feature.

we may have to add a line which checks whether has_gaze_files is true. if not true, skip test.

secondly, we may have to add integration tests, for datasets which just have has_precomputed_event_files. this might be more difficult as we do not enforce any standardized notations.

Copy link
Member

@prassepaul prassepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only change the small thing pointed out... really big PR...

@SiQube SiQube enabled auto-merge (squash) August 26, 2024 14:19
@SiQube SiQube merged commit a053cd5 into main Aug 26, 2024
21 checks passed
@SiQube SiQube deleted the fixation-dataset branch August 26, 2024 14:22
@SiQube SiQube mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for event-only datasets
2 participants