-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable fixation only datasets #771
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 61 +1
Lines 2817 2914 +97
Branches 759 779 +20
=========================================
+ Hits 2817 2914 +97 ☔ View full report in Codecov by Sentry. |
for pre-commit ci to pass need to merge #774 first |
resolves #716 |
we have to think about integration tests when considering this feature. we may have to add a line which checks whether secondly, we may have to add integration tests, for datasets which just have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would only change the small thing pointed out... really big PR...
eventually resolves #716