Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge tests for public datasets in a single file #785

Merged
merged 7 commits into from
Sep 2, 2024

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Aug 22, 2024

merged public datasets utilities into single file.

resolves #381

I stumbled upon this issue when working on #379. I think this is user friendlier to add more datasets (just add one line to public_dataset parametrize in in the file instead of copying file etc.)

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (968e418) to head (9272da0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #785   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         2946      2946           
  Branches       782       782           
=========================================
  Hits          2946      2946           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiQube SiQube force-pushed the refactor-datasets-tests branch from 22e8b2c to 48b29c6 Compare August 22, 2024 11:43
@SiQube SiQube enabled auto-merge (squash) September 2, 2024 09:15
@SiQube SiQube merged commit 054d567 into main Sep 2, 2024
21 checks passed
@SiQube SiQube deleted the refactor-datasets-tests branch September 2, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor specific dataset tests in a single file
2 participants