-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Falling snow brush #172
base: master
Are you sure you want to change the base?
Falling snow brush #172
Conversation
src/brushes/snow.js
Outdated
this.geometry.attributes.position.needsUpdate = true; | ||
this.geometry.attributes.linePosition.needsUpdate = true; | ||
|
||
this.geometry.setDrawRange(0, this.data.numPoints * this.subdivisions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does subdivisions
means? I believe it should be ' * FLAKES_PER_POINT` isn't it?
good catch, i didn't notice the thousands of flakes drawing at exactly 0,0,0. Updated. |
|
…random in the vertex shader, cap the minimum flake size
Ok updated all three
|
Nice addition! I would animate the rotation and add some scale variation to the flakes, but it is nice as it is too :) I tested the last commit, and everything looks fine, but:
Merry Christmas! |
The holidays are almost here, and i've lived in california so long i've forgotten that there's supposed to be snow!
I've implemented a falling snow brush, that uses a point-sprite cloud, and vertex shaders to make them fall nicely.
I also added a binary=true flag for the loading of a demo.apa file which seems to have broken