message d'erreur spécifique en cas d'utilisateur déjà existant lors de l'inscription #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function findOneByUsername($username) | ||
| { | ||
| $sql = 'SELECT * FROM Member WHERE username = ? AND active = true LIMIT 1'; |
There was a problem hiding this comment.
C'est quoi déjà ce champ "active" ?
There was a problem hiding this comment.
Ce champ est utilisé :
- sur la page de mot de passe oublié
- sur la page permettant de récupérer le mot de passe (lien envoyé par mail)
(sur ces deux pages, on vérifie si l'utilisateur est actif avant de d'envoyer le mail ou changer le mot de passe)
Il est de plus utilisé lors de la récupération de l'utilisateur sur la page de login (un utilisateur inactif ne peut pas se logguer).
Il n'y a actuellement aucun moyen de modifier ce champ via l'interface.
Je ne sais pas si certains membres sont indiqués comme inactifs (depuis les données récupérées de l'ancienne version).
There was a problem hiding this comment.
Il y a du coup pour moi une erreur dans le check sur le username : si ce username existe mais est inactif, on ne va pas le détecter, mais il y aura un problème d'enregistrement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf issue #60 et issue #72