Merge pull request #1388 from Mopolo/phpstan-missing-returns

Ajout de return demandés par l'interface
afup · Dec 19, 2023 · d871e47 · d871e47
2 parents a49de0a + 531edfe
commit d871e47
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/sources/AppBundle/Security/LegacyAuthenticator.php b/sources/AppBundle/Security/LegacyAuthenticator.php
@@ -70,6 +70,8 @@ public function checkCredentials($credentials, UserInterface $user)
     public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
     {
         $request->getSession()->getFlashBag()->add('error', "Utilisateur et/ou mot de passe incorrect");
+
+        return null;
     }
 
     /**

diff --git a/sources/AppBundle/Security/LegacyHashAuthenticator.php b/sources/AppBundle/Security/LegacyHashAuthenticator.php
@@ -62,6 +62,8 @@ public function checkCredentials($credentials, UserInterface $user)
     public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
     {
         $request->getSession()->getFlashBag()->add('error', "Utilisateur et/ou mot de passe incorrect");
+
+        return null;
     }
 
     /**

diff --git a/sources/AppBundle/Security/TestGithubAuthenticator.php b/sources/AppBundle/Security/TestGithubAuthenticator.php
@@ -106,11 +106,9 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
         return new JsonResponse($data, 403);
     }
 
-    /**
-     * @inheritDoc
-     */
     public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)
     {
+        return null;
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up @@
         public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
         {
             $request->getSession()->getFlashBag()->add('error', "Utilisateur et/ou mot de passe incorrect");
+            return null;
         }
         /**
@@ Expand Down @@