Refactor de la liste des antennes en DTOs #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mopolo
force-pushed
the
refactor-list-antennes-dto
branch
from
5aab91d to
752061f
Compare
Mopolo
force-pushed
the
refactor-list-antennes-dto
branch
6 times, most recently
from
0f1fb94 to
8a05292
Compare
Mopolo
changed the title
There was a problem hiding this comment.
@Mopolo super job franchement bravo d'avoir entrepris ce gros refacto sur office/antenne ça fait du bien et ça va être pratique pour la suite.
Bientôt on pourra utiliser readonly, les promoted properties, les enums etc 😉😅
Quelques petites suggestions au passage
Mopolo
force-pushed
the
refactor-list-antennes-dto
branch
from
8a05292 to
42e2f5d
Compare
stakovicz
approved these changes
Feb 10, 2025
Mopolo
force-pushed
the
refactor-list-antennes-dto
branch
from
42e2f5d to
ae11467
Compare
Mopolo
force-pushed
the
refactor-list-antennes-dto
branch
from
ae11467 to
25a3898
Compare
stakovicz
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans cette PR la classe
OfficesCollectionest remplacée par une classeAntennesCollectionmieux typée.Cette nouvelle classe a les mêmes méthodes que l'ancienne mais retourne des DTOs au lieu d'un grand tableau non typé.
Les DTOs ont des propriétés publiques volontairement en prévision de PHP 8.1 et du
readonlynatif. En attendant les classes sont marquées d'un@readonlyqui est déjà pris en compte par PHPStan à partir du niveau 3 (et on est au 2 donc pas de bêtises 😄 !).Ce changement n'est sensé avoir aucun impact en front.