-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Contributors Page #162
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Arnabdaz Review the PR |
change the name of the both of the files (dont use App.jsx and index.js) and move the css to a seperate css file |
@Arnabdaz I have done the required changes, please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rohitn-2312 contributors page not showing up in the deployed page please check and fix
you can see the vercel bot made a deploy preview which links to https://pollitup-kt95v42py-agamjotsingh18.vercel.app/
fix the issue
I will fix the issue. |
no I did not notice at first but the contributors page and contributors link at navbar is not there in the vercel preview deploy at https://pollitup-kt95v42py-agamjotsingh18.vercel.app/ you need to fix that |
Hey @Arnabdaz , Can you install @primer/octicons-react as without this I am getting problem in compiling the code. |
Just do |
@Arnabdaz I did the same and almost tried everything but it's showing error . |
i would take a look |
@Arnabdaz Any update? |
sorry for late reply try with |
@Arnabdaz Didn't work |
ok i added octicons-react for you pull the latest commit and it should be available in your in the package.json ... after that just npm install or npm install --legacy-peer-deps and you should have it in your node modules. |
@Arnabdaz I have added the contributor in navbar but it is not rendering to the contributors page . Would be helpful if you can help me with this |
Please push the latest changes |
Done! |
@Arnabdaz I have pushed the changes , kindly help me with the issue |
So what is the problem you are facing right now, can you elaborate. |
I have added contributors section in the navbar but on clicking it , it's not redirected to the contributors page. |
Try fixing the route in app.jsx for redirecting to the contributors page @Rohitn-2312 |
Pull Request Template
Description
This pull request adds a contributors page to the website. The contributors page showcases a list of contributors to the project fetched from the GitHub API. It also includes a motivation section, a GitHub link to the project repository, and a "Start Contributing" button. Additionally, a new title "Contribute" has been added above the motivation section to provide clarity to potential contributors.
Fixes #139
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration:
Checklist: