Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Contributors Page #162

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

Rohitn-2312
Copy link

@Rohitn-2312 Rohitn-2312 commented Jun 5, 2023

Pull Request Template

Description

This pull request adds a contributors page to the website. The contributors page showcases a list of contributors to the project fetched from the GitHub API. It also includes a motivation section, a GitHub link to the project repository, and a "Start Contributing" button. Additionally, a new title "Contribute" has been added above the motivation section to provide clarity to potential contributors.

Fixes #139

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Tested the contributors page locally by running the application and verifying that the contributors' avatars and usernames are displayed correctly.
  • Verified that the GitHub link opens the project repository in a new tab.
  • Clicked on the "Start Contributing" button to ensure it is functional and redirects to the appropriate destination.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pollitup 🛑 Canceled (Inspect) Jun 12, 2023 6:27pm

@Rohitn-2312
Copy link
Author

@Arnabdaz Review the PR

@Arnabdaz
Copy link
Collaborator

Arnabdaz commented Jun 6, 2023

change the name of the both of the files (dont use App.jsx and index.js) and move the css to a seperate css file

@Rohitn-2312
Copy link
Author

@Arnabdaz I have done the required changes, please have a look.

Arnabdaz
Arnabdaz previously approved these changes Jun 6, 2023
Copy link
Collaborator

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rohitn-2312 contributors page not showing up in the deployed page please check and fix
you can see the vercel bot made a deploy preview which links to https://pollitup-kt95v42py-agamjotsingh18.vercel.app/
fix the issue

@Arnabdaz Arnabdaz self-requested a review June 6, 2023 16:16
@Rohitn-2312
Copy link
Author

Rohitn-2312 commented Jun 6, 2023

I will fix the issue.

@Arnabdaz
Copy link
Collaborator

Arnabdaz commented Jun 6, 2023

Thanks for approving

no I did not notice at first but the contributors page and contributors link at navbar is not there in the vercel preview deploy at https://pollitup-kt95v42py-agamjotsingh18.vercel.app/ you need to fix that

@Arnabdaz Arnabdaz dismissed their stale review June 6, 2023 16:21

re-review

@Rohitn-2312
Copy link
Author

Hey @Arnabdaz , Can you install @primer/octicons-react as without this I am getting problem in compiling the code.

@Arnabdaz
Copy link
Collaborator

Arnabdaz commented Jun 7, 2023

Hey @Arnabdaz , Can you install @primer/octicons-react as without this I am getting problem in compiling the code.

Just do npm install <your package name> and it would be added to package.json and next when someone pulls the changes and does npm install will have it

@Rohitn-2312
Copy link
Author

Hey @Arnabdaz , Can you install @primer/octicons-react as without this I am getting problem in compiling the code.

Just do npm install <your package name> and it would be added to package.json and next when someone pulls the changes and does npm install will have it

@Arnabdaz I did the same and almost tried everything but it's showing error .

@Arnabdaz
Copy link
Collaborator

Arnabdaz commented Jun 8, 2023

Hey @Arnabdaz , Can you install @primer/octicons-react as without this I am getting problem in compiling the code.

Just do npm install <your package name> and it would be added to package.json and next when someone pulls the changes and does npm install will have it

@Arnabdaz I did the same and almost tried everything but it's showing error .

i would take a look

@Rohitn-2312
Copy link
Author

@Arnabdaz Any update?

@Arnabdaz
Copy link
Collaborator

@Arnabdaz Any update?

sorry for late reply try with npm install @primer/octicons-react --legacy-peer-deps if it does not work let me know i would check then

@Rohitn-2312
Copy link
Author

@Arnabdaz Didn't work

@Arnabdaz
Copy link
Collaborator

@Arnabdaz Didn't work

ok i added octicons-react for you pull the latest commit and it should be available in your in the package.json ... after that just npm install or npm install --legacy-peer-deps and you should have it in your node modules.

@Rohitn-2312
Copy link
Author

@Arnabdaz I have added the contributor in navbar but it is not rendering to the contributors page . Would be helpful if you can help me with this
2023-06-12

@Arnabdaz
Copy link
Collaborator

@Arnabdaz I have added the contributor in navbar but it is not rendering to the contributors page . Would be helpful if you can help me with this
2023-06-12

Please push the latest changes

@Rohitn-2312
Copy link
Author

@Arnabdaz I have added the contributor in navbar but it is not rendering to the contributors page . Would be helpful if you can help me with this
2023-06-12

Please push the latest changes

Done!

@Rohitn-2312
Copy link
Author

Rohitn-2312 commented Jun 13, 2023

@Arnabdaz I have pushed the changes , kindly help me with the issue

@debsouryadatta
Copy link
Contributor

@Arnabdaz I have pushed the changes , kindly help me with the issue

So what is the problem you are facing right now, can you elaborate.

@Rohitn-2312
Copy link
Author

So what is the problem you are facing right now, can you elaborate.

I have added contributors section in the navbar but on clicking it , it's not redirected to the contributors page.

@karthiknadar1204
Copy link

Try fixing the route in app.jsx for redirecting to the contributors page @Rohitn-2312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Contributors Page
4 participants