You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
[ x] Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test A
Test B
Test Configuration:
Firmware version:
Hardware:
Toolchain:
SDK:
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings
@An525ish the code seems fine but just wanted to ask if you could match the formatting of your editor to match the codebase it would be easier to review, follow up and understand in future
@An525ish the code seems fine but just wanted to ask if you could match the formatting of your editor to match the codebase it would be easier to review, follow up and understand in future
what i meant was if you see the files changed section you will see a lot of unnecessary changes due to the change in the code structure like some line divided into multiple lines , new space addition, quotes change etc ... if everyone use their own formatting settings then the whole codebase will be a mess ... thats what i was trying to tell you that you should remove the unintentional changes which are showing up in the pr
what i meant was if you see the files changed section you will see a lot of unnecessary changes due to the change in the code structure like some line divided into multiple lines , new space addition, quotes change etc ... if everyone use their own formatting settings then the whole codebase will be a mess ... thats what i was trying to tell you that you should remove the unintentional changes which are showing up in the pr
Okkkay...I changed the format to compact...can u have a look and suggest if there are any more changes required
what i meant was if you see the files changed section you will see a lot of unnecessary changes due to the change in the code structure like some line divided into multiple lines , new space addition, quotes change etc ... if everyone use their own formatting settings then the whole codebase will be a mess ... thats what i was trying to tell you that you should remove the unintentional changes which are showing up in the pr
Okkkay...I changed the format to compact...can u have a look and suggest if there are any more changes required
looks better now but the vecel deployment is failing can you fix that
what i meant was if you see the files changed section you will see a lot of unnecessary changes due to the change in the code structure like some line divided into multiple lines , new space addition, quotes change etc ... if everyone use their own formatting settings then the whole codebase will be a mess ... thats what i was trying to tell you that you should remove the unintentional changes which are showing up in the pr
Okkkay...I changed the format to compact...can u have a look and suggest if there are any more changes required
looks better now but the vecel deployment is failing can you fix that
I tried updating the branch..but it is still failing..what to do now..?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # 81
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: