-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ refactor ] Add Data.Nat.SumAndProduct
#2558
base: master
Are you sure you want to change the base?
Conversation
I have to say, I don't like the module name... there are other monoids on Nat (e.g. (max, 0)) whose folds we'd also want to have in the same module if we have them. |
Thanks @Taneb ! Bear in mind that I regard this PR as provisional, indeed minimal wrt not refactoring to lift out the actual Eg, I could even imagine doing that generalisation (in whatever form) downstream, and then simply deprecating this module with its 'clunky' name. perhaps I even thought that would be inevitable, so either didn't care, or actively chose, to make the name 'clunky'... on a 'build one to throw away' principle... That said, would (any of) the following be better candidate names?
Other suggestions welcome! @JacquesCarette any thoughts on this? |
As I said elsewhere, fully agree with moving these out of where they currently are. Hmm, why If it were in |
Implements the 'provisional' v2.3 fix for #2553 .
NB.:
CHANGELOG
in anticipation of Update documentation from v2.2 release version to v2.3-dev #2557 being mergedData.List.Properties
concerningsum-++-commute
, but now the message is... anachronistic. Wasn't sure how to deal with this properly!Data.Nat.Primality.Factorisation
when generating the HTML index, but not when testingstdlib
! Nor why it is being generated... but I may have forgotten the fine(r) points about how this works... :-( UPDATED: seemingly FIXED now!?