-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ refactor ] Restate, and use, the definitions of Monotonic
etc. operations
#2580
Draft
jamesmckinna
wants to merge
28
commits into
agda:master
Choose a base branch
from
jamesmckinna:issue1579
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
52aaead
refactor: use the definitions!
jamesmckinna e19936c
add: `LeftMonotonic` and `RightMonotonic`
jamesmckinna 3ac9569
refactor: systematise `Congruence` reasoning
jamesmckinna a6710a0
fix: knock-on DRY
jamesmckinna 02a2d5a
fix: `CHANGELOG` plus cosmetics
jamesmckinna d9c1136
refactor: change implicit to explicit
jamesmckinna c175970
fix: make `CHANGELOG` more detailed
jamesmckinna 84c579c
refactor: rectify the names
jamesmckinna 0ffa707
refactor: use the new definitions
jamesmckinna 54b310d
refactor: use the new definitions some more
jamesmckinna f18f031
refactor: use the new definitions some more
jamesmckinna 7bc97ce
refactor: unsolved metas make this a pain!
jamesmckinna 0cb6671
refactor: use the new definitions
jamesmckinna 17f626d
refactor: use the new definitions
jamesmckinna 376c6da
refactor: use the new lemma statements; not yet their generic proofs
jamesmckinna 87e0cb1
add: missing redefinitions
jamesmckinna c9e356e
refactor: use new lemma
jamesmckinna 8528926
refactor: one more use of `Monotonic₁`
jamesmckinna 9acf427
Merge branch 'master' into issue1579
jamesmckinna d3ed088
refactor: `Congruent` in terms of `Monotonic`
jamesmckinna 7fff276
refactor: de-nest `module Congruence`
jamesmckinna 49c0854
fix: tighten `import`s
jamesmckinna d1d0617
Merge branch 'master' into issue1579
jamesmckinna 071d50d
fix: make relation arguments explicit
jamesmckinna 4fd70c9
Merge branch 'master' into issue1579
jamesmckinna 2c82f42
fix: explicit imports
jamesmckinna adf424b
fix: parameterisation of proofs
jamesmckinna 2601ae5
fix: parameterisation of `mono` proofs
jamesmckinna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why put the
open Definitions
in the module telescope instead of on the line below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because in each case, my conviction is:
_≈_
argumentsAlgebra.Consequences.*
? #2502 / [ refactor ] Add equality as a parameter toAlgebra.Consequences.Base
#2572with the latter being on the model of how
Algebra.Definitions
is imported instantiated by_≈_
inAlgebra.Structures
etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you misunderstood my point. I want that
open
there, just inside the module instead of in the telescope!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but I had been maintaining consistency with the other two, where the
open
declaration is required in the module telescope, in order to be able to state the hypotheses without reference to equality...