-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdcard_image-rpi.bbclass: include ${IMAGE_NAME_SUFFIX} directly in bo… #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Feb 22, 2024
:Release Notes: OSE doesn't use rpi-sdimg since: 2019 with "webos-sota.inc: enable FOTA by using ostree" upstream meta-raspberrypi doesn't use it by default since: 722d8376 in 2020: agherzan/meta-raspberrypi@722d837 so this duplicated bbclass got a bit rusty over time. :Detailed Notes: Import following changes from upstream meta-raspberrypi: 831b985 sdcard_image-rpi.bbclass: include ${IMAGE_NAME_SUFFIX} directly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} 1440ac8 sdcard_image-rpi.bbclass: Move SDIMG_KERNELIMAGE definitions to their machines 9340e20 sdcard_image-rpi.bbclass: Use processed list of device trees e0fc680 sdcard_image-rpi: fix DeprecationWarning c7f4c73 sdcard_image-rpi.bbclass: Fix IMAGE_TYPEDEP override to use new syntax 3f703e1 Manually fix conversion 9ea7aa2 Convert to new override syntax 853ccd7 sdcard_image-rpi.bbclass: shorten the default BOOTDD_VOLUME_ID 10d21b8 sdcard_image-rpi.bbclass: increase default boot partition size from 40MiB to 48MiB ba3a417 rpi-bootfiles: Rename recipe to avoid ambiguity ba6a809 sdcard_image-rpi: Drop redundant dependency on rpi-config:do_deploy The top one is pending review in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRP-29491] Create GPVB with Yocto 5.0 Scarthgap
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Feb 22, 2024
…FIX} directly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c sent upstream in: agherzan/meta-raspberrypi#1289 :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRP-13301] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Feb 22, 2024
…ta-raspberrypi :Release Notes: OSE doesn't use rpi-sdimg since: 2019 with "webos-sota.inc: enable FOTA by using ostree" upstream meta-raspberrypi doesn't use it by default since: 722d8376 in 2020: agherzan/meta-raspberrypi@722d837 so this duplicated bbclass got a bit rusty over time. :Detailed Notes: Import following changes from upstream meta-raspberrypi: 831b985 sdcard_image-rpi.bbclass: include ${IMAGE_NAME_SUFFIX} directly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} 1440ac8 sdcard_image-rpi.bbclass: Move SDIMG_KERNELIMAGE definitions to their machines 9340e20 sdcard_image-rpi.bbclass: Use processed list of device trees e0fc680 sdcard_image-rpi: fix DeprecationWarning c7f4c73 sdcard_image-rpi.bbclass: Fix IMAGE_TYPEDEP override to use new syntax 3f703e1 Manually fix conversion 9ea7aa2 Convert to new override syntax 853ccd7 sdcard_image-rpi.bbclass: shorten the default BOOTDD_VOLUME_ID 10d21b8 sdcard_image-rpi.bbclass: increase default boot partition size from 40MiB to 48MiB ba3a417 rpi-bootfiles: Rename recipe to avoid ambiguity ba6a809 sdcard_image-rpi: Drop redundant dependency on rpi-config:do_deploy The top one is pending review in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRP-29491] Create GPVB with Yocto 5.0 Scarthgap
…th ${IMAGE_NAME} and ${IMAGE_LINK_NAME} * Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * without this fix, build with: IMAGE_FSTYPES:rpi = "rpi-sdimg.gz" will fail due to duplicated .rootfs suffix as shown in: http://errors.yoctoproject.org/Errors/Details/754267/ 130023424 bytes (130 MB, 124 MiB) copied, 0.0706353 s, 1.8 GB/s gzip: skipping: core-image-minimal-raspberrypi4-64.rootfs-20240222111049.rpi-sdimg does not exist WARNING: TOPDIR/tmp-glibc/work/raspberrypi4_64-oe-linux/core-image-minimal/1.0/temp/run.do_image_rpi_sdimg.1238835:263 exit 1 from 'gzip -f -9 -n -c --rsyncable core-image-minimal-raspberrypi4-64.rootfs-20240222111049.rpi-sdimg > core-image-minimal-raspberrypi4-64.rootfs-20240222111049.rpi-sdimg.gz' OE raspberrypi4-64@ /OE/build/oe-core/tmp-glibc/work/raspberrypi4_64-oe-linux/core-image-minimal/1.0/deploy-core-image-minimal-image-complete $ ll total 305612 drwxr-xr-x 2 martin martin 4096 Feb 22 12:12 ./ drwxr-xr-x 17 martin martin 4096 Feb 22 12:12 ../ -rw-r--r-- 1 martin martin 130023424 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs-20240222111049.ext3 -rw-r--r-- 1 martin martin 3535 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs-20240222111049.manifest -rw-r--r-- 1 martin martin 184549376 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs-20240222111049.rootfs.rpi-sdimg -rw-r--r-- 1 martin martin 0 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs-20240222111049.rpi-sdimg.gz -rw-r--r-- 1 martin martin 361441 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs-20240222111049.spdx.tar.zst -rw-r--r-- 1 martin martin 271541 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs-20240222111049.testdata.json -rw-r--r-- 1 martin martin 50331648 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs-20240222111049.vfat lrwxrwxrwx 1 martin martin 61 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs.ext3 -> core-image-minimal-raspberrypi4-64.rootfs-20240222111049.ext3 lrwxrwxrwx 1 martin martin 65 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs.manifest -> core-image-minimal-raspberrypi4-64.rootfs-20240222111049.manifest lrwxrwxrwx 1 martin martin 69 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs.spdx.tar.zst -> core-image-minimal-raspberrypi4-64.rootfs-20240222111049.spdx.tar.zst lrwxrwxrwx 1 martin martin 70 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs.testdata.json -> core-image-minimal-raspberrypi4-64.rootfs-20240222111049.testdata.json lrwxrwxrwx 1 martin martin 61 Feb 22 12:12 core-image-minimal-raspberrypi4-64.rootfs.vfat -> core-image-minimal-raspberrypi4-64.rootfs-20240222111049.vfat Signed-off-by: Martin Jansa <[email protected]>
shr-project
force-pushed
the
jansa/patches
branch
from
February 22, 2024 11:15
831b985
to
b11fd30
Compare
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Feb 22, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRP-13301] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
agherzan
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Approved, and thanks!
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Feb 24, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRP-13301] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Feb 26, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRP-13301] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Mar 1, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Mar 10, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Apr 9, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
May 29, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Jun 10, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Jun 10, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Jul 10, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Aug 23, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Nov 5, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Nov 5, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
shr-project
added a commit
to shr-project/meta-webosose
that referenced
this pull request
Dec 3, 2024
…ectly in both ${IMAGE_NAME} and ${IMAGE_LINK_NAME} :Release Notes: Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c :Detailed Notes: * ${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix * it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version. * it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer. * submitted upstream in: agherzan/meta-raspberrypi#1289 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-691] Create GPVB with Yocto 4.3 Nanbield Change-Id: I7b9ba00ae83ac2a155f24602f5eb461de67eceea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…th ${IMAGE_NAME} and ${IMAGE_LINK_NAME}
Adjust to https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c
${IMAGE_NAME}${IMAGE_NAME_SUFFIX} is almost always used together already and when they aren't it's usually because of hardcoded '.rootfs' suffix
it's a bit strange, because ${IMAGE_NAME_SUFFIX} is applied after the version from ${IMAGE_VERSION_SUFFIX}, if we move it to ${IMAGE_LINK_NAME} then it will be applied before the version and ${IMAGE_LINK_NAME} will be just the version-less symlink to latest built version.
it's not added to INITRAMFS_IMAGE_NAME as it assumes that all images used as initramfs will set IMAGE_NAME_SUFFIX to empty. Many already do as shown bellow, but you might need to extend this list in your layer.