-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hpp-fcl -> coal #37
Merged
hpp-fcl -> coal #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim65s
added a commit
that referenced
this pull request
Feb 7, 2025
@Mergifyio rebase |
☑️ Nothing to do
|
@Kotochleb : what should we do about this failing test ? colmpc> ======================================================================
colmpc> FAIL: test_calc (__main__.TestVelocityAvoidance.test_calc)
colmpc> ----------------------------------------------------------------------
colmpc> Traceback (most recent call last):
colmpc> File "/build/source/tests/test_velocity_avoidance.py", line 178, in test_calc
colmpc> self.assertAlmostEqual(
colmpc> AssertionError: np.float64(8.834530107910298) != np.float64(8.834353448314038) within 5 places (np.float64(0.00017665959626000927) difference) : Result missmatch in function ``calc`` between Python and C++implementation!.
colmpc> ======================================================================
colmpc> FAIL: test_calc_diff_finite (__main__.TestVelocityAvoidance.test_calc_diff_finite)
colmpc> ----------------------------------------------------------------------
colmpc> Traceback (most recent call last):
colmpc> File "/build/source/tests/test_velocity_avoidance.py", line 220, in test_calc_diff_finite
colmpc> np.testing.assert_allclose(
colmpc> File "/nix/store/xji7f8c2303yjxp4393y7vwj1wlffcnm-python3.12-numpy-2.2.0/lib/python3.12/site-packages/numpy/testing/_private/utils.py", line 1678, in assert_allclose
colmpc> assert_array_compare(compare, actual, desired, err_msg=str(err_msg),
colmpc> File "/nix/store/xji7f8c2303yjxp4393y7vwj1wlffcnm-python3.12-numpy-2.2.0/lib/python3.12/site-packages/numpy/testing/_private/utils.py", line 884, in assert_array_compare
colmpc> raise AssertionError(msg)
colmpc> AssertionError:
colmpc> Not equal to tolerance rtol=1e-09, atol=1e-09
colmpc> Result missmatch in function ``calcDiff`` between C++ implementation and python implementation!.
colmpc> Mismatched elements: 14 / 14 (100%)
colmpc> Max absolute difference among violations: 0.0071246
colmpc> Max relative difference among violations: 0.0059036
colmpc> ACTUAL: array([ 1.236538, 3.745628, 6.082169, -3.663471, -2.296124, 2.476514, -0.346822, -0.079835, -0.178627, -0.31301 , 0.218428, 0.131093, -0.100388, -0.014509])
colmpc> DESIRED: array([ 1.236034, 3.741866, 6.075044, -3.662399, -2.294085, 2.473528, -0.347269, -0.079858, -0.17865 , -0.313027, 0.218016, 0.130818, -0.100558, -0.014424])
colmpc> ---------------------------------------------------------------------- |
My wild guess is that default tolerances in Coal were changes since we worked on that. @ArthurH91 could you take a look at it as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start working on hpp-fcl -> coal transition.
This might require another pass when the same work wil be done in pinocchio, (at least remove the
COAL_BACKWARD_COMPATIBILITY_WITH_HPP_FCL
flag).While here, enable some unittests, enable PTH ruff lint and implement it, and bump pinocchio.
2 tests are currently failing for me with: