Skip to content

Commit

Permalink
Remove useless bop deps in megapose
Browse files Browse the repository at this point in the history
  • Loading branch information
MedericFourmy committed Oct 17, 2023
1 parent 6a9b172 commit b435323
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 22 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ __pycache__
*.cpython
experiments/outputs
/book
happypose/pose_estimators/cosypose/build/
6 changes: 0 additions & 6 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
[submodule "happypose/pose_estimators/cosypose/deps/bop_toolkit_challenge"]
path = happypose/pose_estimators/cosypose/deps/bop_toolkit_challenge
url = https://github.com/ylabbe/bop_toolkit_challenge20.git
[submodule "happypose/pose_estimators/cosypose/deps/bop_toolkit_cosypose"]
path = happypose/pose_estimators/cosypose/deps/bop_toolkit_cosypose
url = https://github.com/ylabbe/bop_toolkit_cosypose.git
[submodule "happypose/pose_estimators/cosypose/deps/job-runner"]
path = happypose/pose_estimators/cosypose/deps/job-runner
url = https://github.com/ylabbe/job-runner.git
Expand Down
35 changes: 21 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@ cd ../../..
pip install -e .
```

Installation of bop_toolkit :

```
conda activate happypose
cd happypose/pose_estimators/megapose/deps/bop_toolkit_challenge/
# Remove all versions enforcing on requirements.txt
pip install -r requirements.txt -e .
```


# Create data directory

Expand All @@ -45,11 +36,21 @@ export HAPPYPOSE_DATA_DIR=/somewhere/convenient

# Configuration for the evaluation

If you plan on evaluating CosyPose and Megapose, you need to modify the following lines in `bop_toolkit_lib/config.py`, replace
Installation of bop_toolkit :

```
######## Basic ########
conda activate happypose
cd happypose/deps/bop_toolkit_challenge/
# Remove all versions enforcing on requirements.txt
pip install -r requirements.txt -e .
```

If you plan on evaluating CosyPose and Megapose, you need to modify the paths to data directories used by the bop_toolkit.
A simple solution is to create subfolders in `HAPPYPOSE_DATA_DIR`.
This is done by modifying following lines in `deps/bop_toolkit_challenge/bop_toolkit_lib/config.py`, replace

```
######## Basic ########
# Folder with the BOP datasets.
if 'BOP_PATH' in os.environ:
Expand All @@ -69,10 +70,16 @@ with
```
######## Basic ########
HAPPYPOSE_DATA_DIR = os.environ['HAPPYPOSE_DATA_DIR']
# Folder with the BOP datasets.
datasets_path = str(os.environ['BOP_DATASETS_PATH'])
results_path = str(os.environ['BOP_RESULTS_PATH'])
eval_path = str(os.environ['BOP_EVAL_PATH'])
datasets_path = os.path.join(HAPPYPOSE_DATA_DIR, 'bop_datasets')
# Folder with pose results to be evaluated.
results_path = os.path.join(HAPPYPOSE_DATA_DIR, 'results')
# Folder for the calculated pose errors and performance scores.
eval_path = os.path.join(HAPPYPOSE_DATA_DIR, 'bop_eval_outputs')
```

You will also need to install [TEASER++](https://github.com/MIT-SPARK/TEASER-plusplus) if you want to use the depth for MegaPose. To do so, please run the following commands to install it :
Expand Down
Submodule bop_toolkit_challenge deleted from f11499
Submodule bop_toolkit_cosypose deleted from b13081

0 comments on commit b435323

Please sign in to comment.