Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing cosypose inference pipeline. #63

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Testing cosypose inference pipeline. #63

merged 3 commits into from
Sep 18, 2023

Conversation

petrikvladimir
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #63 (f280979) into dev (fd5c270) will increase coverage by 14.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             dev      #63       +/-   ##
==========================================
+ Coverage   3.52%   18.11%   +14.58%     
==========================================
  Files        156      181       +25     
  Lines      12154    14183     +2029     
==========================================
+ Hits         429     2569     +2140     
+ Misses     11725    11614      -111     
Files Changed Coverage Δ
...se/pose_estimators/megapose/src/megapose/config.py 96.15% <100.00%> (ø)

... and 68 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this !

tests/data/crackers_example/models/obj_000002.ply is ~1MB and tests/data/crackers_example/models/obj_000002.png is ~10MB, maybe it could be downloaded with the datasets ?
This might require additional work on the download scripts and a few hosting / mirroring operations, but it can be worth it, and Alice is already looking into this part I think

@petrikvladimir
Copy link
Collaborator Author

I didn't realize those files were big. I agree they should not be part of the repository; download script seems a natural solution in the future. However, I would like to not postpone merging this test for a long time, so I moved those files to a separate repository on GitHub and cloned it inside the action. @nim65s, is that an acceptable workaround?

Once we have the download script ready, it can be easily updated in the action. If that is acceptable for merging, please do squash-and-merge so that big files are not kept in repo history.

Copy link
Collaborator

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the temporary workaround, thanks !

@nim65s nim65s merged commit 646f7e2 into dev Sep 18, 2023
13 checks passed
@nim65s nim65s deleted the test_cosypose branch September 18, 2023 07:33
@nim65s
Copy link
Collaborator

nim65s commented Sep 18, 2023

This was squashed and force-pushed in 03207c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants