address PR comments

agimus-project · Oct 16, 2024 · b164259 · b164259
1 parent 3f7ffaf
commit b164259
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/happypose_examples/config/cosypose_params.yaml b/happypose_examples/config/cosypose_params.yaml
@@ -11,7 +11,7 @@
     cosypose:
       # Name of BOP dataset, used to load specific weights and object models
       dataset_name: $(var dataset_name)
-      # What type of NN model to use, type of training data used,  'pbr'|'synth+real'
+      # Type of neural network model to use. Available 'pbr'|'synth+real'
       model_type: $(var model_type)
       # Object renderer parameters
       renderer:

diff --git a/happypose_examples/config/cosypose_params_multiview.yaml b/happypose_examples/config/cosypose_params_multiview.yaml
@@ -17,7 +17,7 @@
     cosypose:
       # Name of BOP dataset, used to load specific weights and object models
       dataset_name: $(var dataset_name)
-      # What type of NN model to use, type of training data used,  'pbr'|'synth+real'
+      # Type of neural network model to use. Available 'pbr'|'synth+real'
       model_type: $(var model_type)
       # Object renderer parameters
       renderer:

diff --git a/happypose_examples/launch/common.launch.py b/happypose_examples/launch/common.launch.py
@@ -73,7 +73,7 @@ def generate_launch_description():
         DeclareLaunchArgument(
             "model_type",
             default_value="pbr",
-            description="What type of NN model to use, type of training data used, 'pbr'|'synth+real'.",
+            description="Type of neural network model to use. Available: 'pbr'|'synth+real'.",
         ),
         DeclareLaunchArgument(
             "device",

diff --git a/happypose_examples/launch/single_view_demo.launch.py b/happypose_examples/launch/single_view_demo.launch.py
@@ -78,7 +78,7 @@ def generate_launch_description():
         DeclareLaunchArgument(
             "model_type",
             default_value="pbr",
-            description="What type of NN model to use, type of training data used, 'pbr'|'synth+real'.",
+            description="Type of neural network model to use. Available: 'pbr'|'synth+real'.",
         ),
         DeclareLaunchArgument(
             "device",

diff --git a/happypose_ros/test/test_initialization_params.py b/happypose_ros/test/test_initialization_params.py
@@ -106,7 +106,6 @@ def test_leading_publish_tf(happypose_params: dict) -> None:
             **happypose_params,
             parameter_overrides=[
                 Parameter("cosypose.dataset_name", Parameter.Type.STRING, "ycbv"),
-                Parameter("cosypose.model_type", Parameter.Type.STRING, "synth+real"),
                 Parameter("camera_names", Parameter.Type.STRING_ARRAY, ["cam_1"]),
                 Parameter("cameras.cam_1.leading", Parameter.Type.BOOL, True),
                 Parameter("cameras.cam_1.publish_tf", Parameter.Type.BOOL, True),