-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -j-std
#425
base: master
Are you sure you want to change the base?
Remove -j-std
#425
Conversation
|
Building the repo with
|
* atdgen: Remove option `-j-std`, now it's the default, one cannot generate extended-JSON (#425). | ||
Options `-j-std` and `-std-json` are still available as backward-compatibility no-ops unless | ||
environment variable `ATDGEN_FAIL_DEPRECATED_OPTIONS` is set to `true` in | ||
which case their use results in an exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
@mjambon should we do anything special with PRs that target the "3.0" major version (ie breaking changes we may not want in a minor release)? |
Cf. issue #412
PR checklist
CHANGES.md
is up-to-date