Add EVM integration with Base and Ethereum #406
Conversation
package-lock.json
Outdated
| } | ||
|
|
||
| return { | ||
| hash: process.txHash as `0x${string}`, |
There was a problem hiding this comment.
Can we move this into a types file?
| return { | ||
| hash: process.txHash as `0x${string}`, | ||
| from: fromAddress, | ||
| to: routes.routes[0].steps[0].estimate.approvalAddress as `0x${string}`, |
| const PROVIDER_CONFIG = { | ||
| PRICE_API: 'https://li.quest/v1', | ||
| NATIVE_TOKEN: { | ||
| ethereum: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', | ||
| base: '0x4200000000000000000000000000000000000006' | ||
| } | ||
| } as const |
There was a problem hiding this comment.
We should add a type and move the hardcoded values into a constants file
| const PROVIDER_CONFIG = { | ||
| PRICE_API: 'https://li.quest/v1', | ||
| NATIVE_TOKEN: { | ||
| ethereum: '0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2', | ||
| base: '0x4200000000000000000000000000000000000006' | ||
| } | ||
| } |
There was a problem hiding this comment.
same here re moving to constants or config file and removing hard coded values
There was a problem hiding this comment.
constants makes sense, config doesn't just because WETH addrs are unchanging these days, so no need to inflate a config file
|
working on all of these now, thank you guys for the quick reviews! |
|
It would be cool to add a token creation action similar to the pump.fun action in the Solana plugin. I've done similar stuff before using the Mint Club protocol, which is similar to pump.fun but designed for EVMs and offers more flexibility. References: Since adding this action is related to this EVM integration PR and will likely depend on it, I’d like to hear your thoughts on it. |
|
absolutely, I think a modular approach to token creation and other general evm-related actions would be appropriate to include. this PR is intended to be a first iteration of EVM capabilities with the goal being to add more actions, chains, etc. over time. please feel free to make any changes/improvements to this! |
I can take a stab at this if you havent already |
|
@chandognft Oh, I haven't yet. I've been learning more about Eliza's structure, which has been taking some time. It would be great if you could take a stab at this right away! 😊 |
|
Looking forward to these being finished - tons of ideas that can be realised once it is merged in. |
|
What's required to get this merged in? Happy to help with any implementation |
Theres some remaining work currently we are working on |
Relates to:
Ethereum and Base integration: #303
Risks
High: involves new chain and protocol capabilities via the LI.FI SDK
Background
What does this PR do?
Adds the
plugin-evmpackageWhat kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
My changes require a change to the project documentation. (WIP)
Testing
Still in progress